From: "Jan Beulich" <JBeulich@suse.com>
To: "Olaf Hering" <olaf@aepfle.de>,"Wei Liu" <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [Xen-devel] libxl assertion failure when creating any kind of guest
Date: Wed, 22 May 2019 02:40:51 -0600 [thread overview]
Message-ID: <5CE50B130200007800231359@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190522084051.8gwmGuI-3JvQ9OYXhqhZYCS90VOhnbCyKzrJzarwKGI@z> (raw)
In-Reply-To: <20190522092544.2d7d835f.olaf@aepfle.de>
>>> On 22.05.19 at 09:25, <olaf@aepfle.de> wrote:
> Am Wed, 22 May 2019 01:11:54 -0600
> schrieb "Jan Beulich" <JBeulich@suse.com>:
>
>> libxl__domain_build_info_setdefault (gc=0x7fffffffdee0,
> b_info=0x7fffffffdb80)
>> at libxl_create.c:143
>
> This is libxl_defbool_val(b_info->device_model_stubdomain).
>
> Due to the lack of a proper way to describe all the dependencies within
> libxl I suggest to revert these commits for the time being:
>
> 278c64519c libxl: fix libxl_domain_need_memory after 899433f149d
> 899433f149 libxl: fix migration of PV and PVH domUs with and without qemu
> 3802ecbaa9 libxl: add helper function to set device_model_version
Well, the alternative is the one line change below.
Jan
libxl: further fix libxl_domain_need_memory() after 899433f149d
Besides providing a device_model_version setting (as done by 278c64519c
["libxl: fix libxl_domain_need_memory after 899433f149d"]), one is also
needed for device_model_stubdomain, or else the respective assert() in
libxl_defbool_val() (called from libxl__domain_build_info_setdefault())
will trigger.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- unstable.orig/tools/libxl/libxl_mem.c
+++ unstable/tools/libxl/libxl_mem.c
@@ -472,6 +472,7 @@ int libxl_domain_need_memory(libxl_ctx *
* calculation doesn't really care which QEMU is set here, so we
* go with the upstream default.
*/
+ libxl_defbool_setdefault(&b_info->device_model_stubdomain, false);
if (!b_info->device_model_version)
b_info->device_model_version = LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-22 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 7:11 libxl assertion failure when creating any kind of guest Jan Beulich
2019-05-22 7:11 ` [Xen-devel] " Jan Beulich
2019-05-22 7:25 ` Olaf Hering
2019-05-22 7:25 ` [Xen-devel] " Olaf Hering
2019-05-22 8:09 ` Wei Liu
2019-05-22 8:09 ` [Xen-devel] " Wei Liu
2019-05-22 8:40 ` Jan Beulich [this message]
2019-05-22 8:40 ` Jan Beulich
2019-05-22 10:01 ` Wei Liu
2019-05-22 10:01 ` [Xen-devel] " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CE50B130200007800231359@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).