xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH 4/6] osstest: introduce a helper to get the svn revision of a git commit
Date: Fri, 24 May 2019 10:57:27 +0100	[thread overview]
Message-ID: <20190524095727.su3wxkxgovfxpyne@Air-de-Roger> (raw)
In-Reply-To: <23782.28680.411030.121451@mariner.uk.xensource.com>

On Thu, May 23, 2019 at 11:03:52AM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[Xen-devel] [PATCH 4/6] osstest: introduce a helper to get the svn revision of a git commit"):
> > This only works when the svn revision is stored as a git note
> > with the format 'revision=<revision number>'.
> 
> Wow.  This is pretty ugly.

Indeed :(.

> 
> > Such conversion is required in order to bootstrap a FreeBSD system
> > without relying on external package repositories. FreeBSD base system
> > only contains a subversion client (no git client), and thus in order
> > to fetch the ports repository (that contain the external packages
> > build makefiles) svn must be used.
> 
> git notes have some different way of travelling than commits, don't
> they ?  Where is this git note coming from and how do we know it is
> the right note, IYSWIM ?

I'm not an expert on this, but I think notes are always stored in a
separate branch on the same repo? In the FreeBSD case at least it's
git/refs/notes.

> Aside from that, please break the refactoring (in this case, the
> breaking out of repo_get_realurl) into a separate NFC patch.

Sure!

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH 4/6] osstest: introduce a helper to get the svn revision of a git commit
Date: Fri, 24 May 2019 10:57:27 +0100	[thread overview]
Message-ID: <20190524095727.su3wxkxgovfxpyne@Air-de-Roger> (raw)
Message-ID: <20190524095727.f8_EPdxQbfYykLyT8IRsSjrjhkiuBGryBa2zh64VnNU@z> (raw)
In-Reply-To: <23782.28680.411030.121451@mariner.uk.xensource.com>

On Thu, May 23, 2019 at 11:03:52AM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[Xen-devel] [PATCH 4/6] osstest: introduce a helper to get the svn revision of a git commit"):
> > This only works when the svn revision is stored as a git note
> > with the format 'revision=<revision number>'.
> 
> Wow.  This is pretty ugly.

Indeed :(.

> 
> > Such conversion is required in order to bootstrap a FreeBSD system
> > without relying on external package repositories. FreeBSD base system
> > only contains a subversion client (no git client), and thus in order
> > to fetch the ports repository (that contain the external packages
> > build makefiles) svn must be used.
> 
> git notes have some different way of travelling than commits, don't
> they ?  Where is this git note coming from and how do we know it is
> the right note, IYSWIM ?

I'm not an expert on this, but I think notes are always stored in a
separate branch on the same repo? In the FreeBSD case at least it's
git/refs/notes.

> Aside from that, please break the refactoring (in this case, the
> breaking out of repo_get_realurl) into a separate NFC patch.

Sure!

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-05-24  9:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 16:59 [PATCH 0/6] osstest: create a local binary FreeBSD package repository Roger Pau Monne
2019-02-20 16:59 ` [PATCH 1/6] osstest: introduce a helper to stash a whole directory Roger Pau Monne
2019-05-23  9:48   ` Ian Jackson
2019-05-23  9:48     ` [Xen-devel] " Ian Jackson
2019-05-24  9:42     ` Roger Pau Monné
2019-05-24  9:42       ` [Xen-devel] " Roger Pau Monné
2019-02-20 16:59 ` [PATCH 2/6] osstest: introduce a helper to create a weblink to a directory Roger Pau Monne
2019-05-23  9:57   ` Ian Jackson
2019-05-23  9:57     ` [Xen-devel] " Ian Jackson
2019-02-20 16:59 ` [PATCH 3/6] osstest: allow to perform multiple anoints in the same transaction Roger Pau Monne
2019-05-23 10:00   ` Ian Jackson
2019-05-23 10:00     ` [Xen-devel] " Ian Jackson
2019-02-20 16:59 ` [PATCH 4/6] osstest: introduce a helper to get the svn revision of a git commit Roger Pau Monne
2019-05-23 10:03   ` Ian Jackson
2019-05-23 10:03     ` [Xen-devel] " Ian Jackson
2019-05-24  9:57     ` Roger Pau Monné [this message]
2019-05-24  9:57       ` Roger Pau Monné
2019-05-24 10:35       ` Ian Jackson
2019-05-24 10:35         ` [Xen-devel] " Ian Jackson
2019-02-20 17:00 ` [PATCH 5/6] osstest: introduce a script to build a FreeBSD package repository Roger Pau Monne
2019-05-23 10:19   ` Ian Jackson
2019-05-23 10:19     ` [Xen-devel] " Ian Jackson
2019-05-23 10:38   ` Ian Jackson
2019-05-23 10:38     ` [Xen-devel] " Ian Jackson
2019-05-24 10:13     ` Roger Pau Monné
2019-05-24 10:13       ` [Xen-devel] " Roger Pau Monné
2019-05-24 11:21       ` Ian Jackson
2019-05-24 11:21         ` [Xen-devel] " Ian Jackson
2019-02-20 17:00 ` [PATCH 6/6] osstest: use a locally built pkg repository for FreeBSD Roger Pau Monne
2019-05-23 11:06   ` Ian Jackson
2019-05-23 11:06     ` [Xen-devel] " Ian Jackson
2019-05-24 10:45     ` Roger Pau Monné
2019-05-24 10:45       ` [Xen-devel] " Roger Pau Monné
2019-05-24 17:26       ` Ian Jackson
2019-05-24 17:26         ` [Xen-devel] " Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524095727.su3wxkxgovfxpyne@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=ian.jackson@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).