From: "Jan Beulich" <JBeulich@suse.com>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Brian Woods <brian.woods@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] AMD/IOMMU: revert "amd/iommu: assign iommu devices to Xen"
Date: Tue, 04 Jun 2019 03:21:08 -0600 [thread overview]
Message-ID: <5CF638040200007800234F11@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190604092108.6QUxOi3nscbIk8E2FVYTAOYr-R6VRZteKqZtqvCFdB4@z> (raw)
In-Reply-To: <abc6106c-0c38-d891-0cbb-5b4d79c8093a@citrix.com>
>>> On 04.06.19 at 11:04, <andrew.cooper3@citrix.com> wrote:
> On 03/06/2019 14:00, Jan Beulich wrote:
>> This reverts commit b6bd02b7a877f9fac2de69e64d8245d56f92ab25. The change
>> was redundant with amd_iommu_detect_one_acpi() already calling
>> pci_ro_device().
>
> Seeing as amd_iommu_detect_one_acpi() hasn't changed for many years, and
> b6bd02b7 was a functional fix for booting PVH on AMD, I can't see what
> would make this true now.
I'd like to counter this: I can't see why that change was needed.
Clearly, if this was indeed needed for PVH Dom0 boot, there was
insufficient reasoning as to why the existing pci_ro_device()
invocation was not enough. I, for one, surely didn't even recall
it was there when reviewing the patch, or else I would have asked
for a more complete description.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-04 9:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 13:00 [PATCH] AMD/IOMMU: revert "amd/iommu: assign iommu devices to Xen" Jan Beulich
2019-06-03 13:00 ` [Xen-devel] " Jan Beulich
2019-06-04 8:48 ` Roger Pau Monné
2019-06-04 8:48 ` [Xen-devel] " Roger Pau Monné
2019-06-04 9:29 ` Jan Beulich
2019-06-04 9:29 ` [Xen-devel] " Jan Beulich
2019-06-04 13:02 ` Jan Beulich
2019-06-04 16:20 ` Roger Pau Monné
2019-06-05 7:55 ` Jan Beulich
2019-06-05 8:02 ` Jan Beulich
2019-06-05 9:52 ` Roger Pau Monné
2019-06-05 9:06 ` Roger Pau Monné
2019-06-05 9:12 ` Andrew Cooper
2019-06-05 9:14 ` Jan Beulich
2019-06-04 9:04 ` Andrew Cooper
2019-06-04 9:04 ` [Xen-devel] " Andrew Cooper
2019-06-04 9:21 ` Jan Beulich [this message]
2019-06-04 9:21 ` Jan Beulich
2019-06-04 12:08 ` Jan Beulich
2019-06-19 16:29 ` Woods, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CF638040200007800234F11@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=brian.woods@amd.com \
--cc=roger.pau@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).