From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, WeiLiu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH 1/4] xz: use initconst for hypervisor build
Date: Wed, 19 Jun 2019 16:44:47 +0200 [thread overview]
Message-ID: <20190619144447.fq5esl5reagv4qpc@MacBook-Air-de-Roger.local> (raw)
In-Reply-To: <5D0A219C0200007800239A00@prv1-mh.provo.novell.com>
On Wed, Jun 19, 2019 at 05:50:52AM -0600, Jan Beulich wrote:
> >>> On 19.06.19 at 13:02, <roger.pau@citrix.com> wrote:
> > Or else clang adds a .init.rodata.cst8 section to the resulting object
> > file, which is not handled by the Xen linker script and can end up
> > before the text section which contains the headers, thus resulting in
> > a not usable binary.
>
> To be honest I'd prefer if we went with just the change suggested
> by Andrew, getting the linker script back in line with
> SPECIAL_DATA_SECTIONS. The static const items in the
> decompressors were left un-annotated intentionally, since the
> .rodata.* thingies want/need taking care of anyway. After all you
> won't (I hope) suggest also annotating the various string literals.
OK, I think regardless of the rest of the lld 8 series it is worth
sending the linker script change in order to prevent having this
orphaned section.
Andrew, since you where the one to propose it, could you please send a
formal patch?
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-19 14:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 11:02 [Xen-devel] [PATCH 0/4] x86: build with llvm 8 linker Roger Pau Monne
2019-06-19 11:02 ` [Xen-devel] [PATCH 1/4] xz: use initconst for hypervisor build Roger Pau Monne
2019-06-19 11:09 ` Andrew Cooper
2019-06-19 11:43 ` Jan Beulich
2019-06-19 11:50 ` Jan Beulich
2019-06-19 14:44 ` Roger Pau Monné [this message]
2019-06-19 11:02 ` [Xen-devel] [PATCH 2/4] x86/linker: use DECL_SECTION uniformly Roger Pau Monne
2019-06-19 11:12 ` Andrew Cooper
2019-06-19 11:02 ` [Xen-devel] [PATCH 3/4] x86/linker: add a reloc section to ELF binary Roger Pau Monne
2019-06-19 11:20 ` Andrew Cooper
2019-06-19 11:56 ` Jan Beulich
2019-06-19 14:30 ` Roger Pau Monné
2019-06-19 14:37 ` Jan Beulich
2019-06-19 12:57 ` Jan Beulich
2019-06-19 15:06 ` Roger Pau Monné
2019-06-21 6:34 ` Jan Beulich
2019-06-21 11:46 ` Roger Pau Monné
2019-06-21 12:07 ` Jan Beulich
2019-06-21 13:41 ` Roger Pau Monné
2019-06-24 11:24 ` Daniel Kiper
2019-06-25 8:10 ` Roger Pau Monné
2019-06-25 9:18 ` Jan Beulich
2019-06-25 11:08 ` Roger Pau Monné
2019-06-25 12:48 ` Roger Pau Monné
2019-06-25 14:18 ` Jan Beulich
2019-06-25 14:11 ` Jan Beulich
2019-06-19 11:02 ` [Xen-devel] [PATCH 4/4] x86: check for multiboot{1, 2} header presence Roger Pau Monne
2019-06-19 11:11 ` Andrew Cooper
2019-06-19 11:20 ` Roger Pau Monné
2019-06-19 11:23 ` Andrew Cooper
2019-06-19 13:08 ` Jan Beulich
2019-06-19 14:40 ` Roger Pau Monné
2019-06-21 6:24 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619144447.fq5esl5reagv4qpc@MacBook-Air-de-Roger.local \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).