From: "Jan Beulich" <JBeulich@suse.com>
To: "Roger Pau Monne" <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Daniel Kiper <daniel.kiper@oracle.com>, WeiLiu <wl@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH 3/4] x86/linker: add a reloc section to ELF binary
Date: Tue, 25 Jun 2019 08:11:33 -0600 [thread overview]
Message-ID: <5D122B95020000780023AF96@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20190625110849.lo7zxh3p5ico4rdd@MacBook-Air-de-Roger.local>
>>> On 25.06.19 at 13:08, <roger.pau@citrix.com> wrote:
> Sorry for not being clear. By remove I mean `git rm
> xen/arch/x86/efi/relocs-dummy.S` and fix the build, like the diff
> appended below.
>
> Is there any reason we should keep the dummy .reloc in the ELF
> output?
Yes, there is. And yes, I was afraid you'd mean this.
> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -39,6 +39,7 @@ extern const intpte_t __page_tables_start[], __page_tables_end[];
> #define PE_BASE_RELOC_HIGHLOW 3
> #define PE_BASE_RELOC_DIR64 10
>
> +#ifdef XEN_BUILD_PE
This is an identifier available to Makefiles only. You also can't propagate
it to .c files, as these get compiled just once to produce _both_ PE and
ELF binary. So while what you suggest may build, it'll result in a broken
xen.efi.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-25 14:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 11:02 [Xen-devel] [PATCH 0/4] x86: build with llvm 8 linker Roger Pau Monne
2019-06-19 11:02 ` [Xen-devel] [PATCH 1/4] xz: use initconst for hypervisor build Roger Pau Monne
2019-06-19 11:09 ` Andrew Cooper
2019-06-19 11:43 ` Jan Beulich
2019-06-19 11:50 ` Jan Beulich
2019-06-19 14:44 ` Roger Pau Monné
2019-06-19 11:02 ` [Xen-devel] [PATCH 2/4] x86/linker: use DECL_SECTION uniformly Roger Pau Monne
2019-06-19 11:12 ` Andrew Cooper
2019-06-19 11:02 ` [Xen-devel] [PATCH 3/4] x86/linker: add a reloc section to ELF binary Roger Pau Monne
2019-06-19 11:20 ` Andrew Cooper
2019-06-19 11:56 ` Jan Beulich
2019-06-19 14:30 ` Roger Pau Monné
2019-06-19 14:37 ` Jan Beulich
2019-06-19 12:57 ` Jan Beulich
2019-06-19 15:06 ` Roger Pau Monné
2019-06-21 6:34 ` Jan Beulich
2019-06-21 11:46 ` Roger Pau Monné
2019-06-21 12:07 ` Jan Beulich
2019-06-21 13:41 ` Roger Pau Monné
2019-06-24 11:24 ` Daniel Kiper
2019-06-25 8:10 ` Roger Pau Monné
2019-06-25 9:18 ` Jan Beulich
2019-06-25 11:08 ` Roger Pau Monné
2019-06-25 12:48 ` Roger Pau Monné
2019-06-25 14:18 ` Jan Beulich
2019-06-25 14:11 ` Jan Beulich [this message]
2019-06-19 11:02 ` [Xen-devel] [PATCH 4/4] x86: check for multiboot{1, 2} header presence Roger Pau Monne
2019-06-19 11:11 ` Andrew Cooper
2019-06-19 11:20 ` Roger Pau Monné
2019-06-19 11:23 ` Andrew Cooper
2019-06-19 13:08 ` Jan Beulich
2019-06-19 14:40 ` Roger Pau Monné
2019-06-21 6:24 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D122B95020000780023AF96@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).