* [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5
@ 2019-06-21 9:30 Olaf Hering
2019-07-02 15:09 ` Anthony PERARD
2019-08-18 17:20 ` Wei Liu
0 siblings, 2 replies; 7+ messages in thread
From: Olaf Hering @ 2019-06-21 9:30 UTC (permalink / raw)
To: xen-devel; +Cc: Olaf Hering, Ian Jackson, Wei Liu
xl(1) opens xl.conf in XEN_CONFIG_DIR.
Substitute this variable also in the man page.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
docs/man/xl.1.pod.in | 2 +-
docs/man/xl.conf.5.pod.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
index 3d64eaa5b2..fb17153635 100644
--- a/docs/man/xl.1.pod.in
+++ b/docs/man/xl.1.pod.in
@@ -50,7 +50,7 @@ setup the bridge.
If you specify the amount of memory dom0 has, passing B<dom0_mem> to
Xen, it is highly recommended to disable B<autoballoon>. Edit
-B</etc/xen/xl.conf> and set it to 0.
+B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
=item run xl as B<root>
diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
index 2beb2119a8..b16036aaeb 100644
--- a/docs/man/xl.conf.5.pod.in
+++ b/docs/man/xl.conf.5.pod.in
@@ -1,6 +1,6 @@
=head1 NAME
-/etc/xen/xl.conf - XL Global/Host Configuration
+@XEN_CONFIG_DIR@/xl.conf - XL Global/Host Configuration
=head1 DESCRIPTION
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5
2019-06-21 9:30 [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5 Olaf Hering
@ 2019-07-02 15:09 ` Anthony PERARD
2019-08-18 17:20 ` Wei Liu
1 sibling, 0 replies; 7+ messages in thread
From: Anthony PERARD @ 2019-07-02 15:09 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel, Ian Jackson, Wei Liu
On Fri, Jun 21, 2019 at 11:30:05AM +0200, Olaf Hering wrote:
> xl(1) opens xl.conf in XEN_CONFIG_DIR.
> Substitute this variable also in the man page.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> docs/man/xl.1.pod.in | 2 +-
> docs/man/xl.conf.5.pod.in | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
> index 3d64eaa5b2..fb17153635 100644
> --- a/docs/man/xl.1.pod.in
> +++ b/docs/man/xl.1.pod.in
> @@ -50,7 +50,7 @@ setup the bridge.
>
> If you specify the amount of memory dom0 has, passing B<dom0_mem> to
> Xen, it is highly recommended to disable B<autoballoon>. Edit
> -B</etc/xen/xl.conf> and set it to 0.
> +B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
>
> =item run xl as B<root>
>
> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
> index 2beb2119a8..b16036aaeb 100644
> --- a/docs/man/xl.conf.5.pod.in
> +++ b/docs/man/xl.conf.5.pod.in
> @@ -1,6 +1,6 @@
> =head1 NAME
>
> -/etc/xen/xl.conf - XL Global/Host Configuration
> +@XEN_CONFIG_DIR@/xl.conf - XL Global/Host Configuration
There's a trailing whitespace, it would be worth removing it. git
complain about it.
The patch seems to depends on "Use XEN_SCRIPT_DIR to refer to
/etc/xen/scripts", but the email doesn't mention it. It would have been
useful to add a note bellow the '---' line or send in a series of patch.
Beside that:
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5
2019-06-21 9:30 [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5 Olaf Hering
2019-07-02 15:09 ` Anthony PERARD
@ 2019-08-18 17:20 ` Wei Liu
2019-08-18 17:27 ` Andrew Cooper
2019-08-19 7:57 ` Olaf Hering
1 sibling, 2 replies; 7+ messages in thread
From: Wei Liu @ 2019-08-18 17:20 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel, Ian Jackson, Wei Liu
On Fri, Jun 21, 2019 at 11:30:05AM +0200, Olaf Hering wrote:
> xl(1) opens xl.conf in XEN_CONFIG_DIR.
> Substitute this variable also in the man page.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> docs/man/xl.1.pod.in | 2 +-
> docs/man/xl.conf.5.pod.in | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
> index 3d64eaa5b2..fb17153635 100644
> --- a/docs/man/xl.1.pod.in
> +++ b/docs/man/xl.1.pod.in
> @@ -50,7 +50,7 @@ setup the bridge.
>
> If you specify the amount of memory dom0 has, passing B<dom0_mem> to
> Xen, it is highly recommended to disable B<autoballoon>. Edit
> -B</etc/xen/xl.conf> and set it to 0.
> +B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
>
> =item run xl as B<root>
>
> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
> index 2beb2119a8..b16036aaeb 100644
> --- a/docs/man/xl.conf.5.pod.in
> +++ b/docs/man/xl.conf.5.pod.in
Sorry for the late reply.
This doesn't apply. There is no such file.
Wei.
> @@ -1,6 +1,6 @@
> =head1 NAME
>
> -/etc/xen/xl.conf - XL Global/Host Configuration
> +@XEN_CONFIG_DIR@/xl.conf - XL Global/Host Configuration
>
> =head1 DESCRIPTION
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5
2019-08-18 17:20 ` Wei Liu
@ 2019-08-18 17:27 ` Andrew Cooper
2019-08-19 8:00 ` Wei Liu
2019-08-19 7:57 ` Olaf Hering
1 sibling, 1 reply; 7+ messages in thread
From: Andrew Cooper @ 2019-08-18 17:27 UTC (permalink / raw)
To: Wei Liu, Olaf Hering; +Cc: xen-devel, Ian Jackson
On 18/08/2019 18:20, Wei Liu wrote:
> On Fri, Jun 21, 2019 at 11:30:05AM +0200, Olaf Hering wrote:
>> xl(1) opens xl.conf in XEN_CONFIG_DIR.
>> Substitute this variable also in the man page.
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> ---
>> docs/man/xl.1.pod.in | 2 +-
>> docs/man/xl.conf.5.pod.in | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
>> index 3d64eaa5b2..fb17153635 100644
>> --- a/docs/man/xl.1.pod.in
>> +++ b/docs/man/xl.1.pod.in
>> @@ -50,7 +50,7 @@ setup the bridge.
>>
>> If you specify the amount of memory dom0 has, passing B<dom0_mem> to
>> Xen, it is highly recommended to disable B<autoballoon>. Edit
>> -B</etc/xen/xl.conf> and set it to 0.
>> +B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
>>
>> =item run xl as B<root>
>>
>> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
>> index 2beb2119a8..b16036aaeb 100644
>> --- a/docs/man/xl.conf.5.pod.in
>> +++ b/docs/man/xl.conf.5.pod.in
> Sorry for the late reply.
>
> This doesn't apply. There is no such file.
Hmm. We have a xl.conf.5.pod which has no substitutions in, and I don't
recall this changing. Perhaps a logical dependency earlier in the SUSE
patch queue?
I think this patch needs a {pod=>pod.in} rename as well, for it to apply
to staging and work as intended.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5
2019-08-18 17:20 ` Wei Liu
2019-08-18 17:27 ` Andrew Cooper
@ 2019-08-19 7:57 ` Olaf Hering
2019-08-19 8:02 ` Wei Liu
1 sibling, 1 reply; 7+ messages in thread
From: Olaf Hering @ 2019-08-19 7:57 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel, Ian Jackson
[-- Attachment #1.1: Type: text/plain, Size: 445 bytes --]
Am Sun, 18 Aug 2019 18:20:26 +0100
schrieb Wei Liu <wl@xen.org>:
> This doesn't apply. There is no such file.
My changes need to be applied in this order, some of them may apply in any order:
20190619120633.27466-1-olaf@aepfle.de
20190619121715.28532-1-olaf@aepfle.de
20190619123818.30747-1-olaf@aepfle.de
20190619130335.3458-1-olaf@aepfle.de
20190621092944.29241-1-olaf@aepfle.de
20190621093005.29329-1-olaf@aepfle.de
Olaf
[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5
2019-08-18 17:27 ` Andrew Cooper
@ 2019-08-19 8:00 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2019-08-19 8:00 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel, Olaf Hering, Ian Jackson, Wei Liu
On Sun, Aug 18, 2019 at 06:27:26PM +0100, Andrew Cooper wrote:
> On 18/08/2019 18:20, Wei Liu wrote:
> > On Fri, Jun 21, 2019 at 11:30:05AM +0200, Olaf Hering wrote:
> >> xl(1) opens xl.conf in XEN_CONFIG_DIR.
> >> Substitute this variable also in the man page.
> >>
> >> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> >> ---
> >> docs/man/xl.1.pod.in | 2 +-
> >> docs/man/xl.conf.5.pod.in | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
> >> index 3d64eaa5b2..fb17153635 100644
> >> --- a/docs/man/xl.1.pod.in
> >> +++ b/docs/man/xl.1.pod.in
> >> @@ -50,7 +50,7 @@ setup the bridge.
> >>
> >> If you specify the amount of memory dom0 has, passing B<dom0_mem> to
> >> Xen, it is highly recommended to disable B<autoballoon>. Edit
> >> -B</etc/xen/xl.conf> and set it to 0.
> >> +B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
> >>
> >> =item run xl as B<root>
> >>
> >> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
> >> index 2beb2119a8..b16036aaeb 100644
> >> --- a/docs/man/xl.conf.5.pod.in
> >> +++ b/docs/man/xl.conf.5.pod.in
> > Sorry for the late reply.
> >
> > This doesn't apply. There is no such file.
>
> Hmm. We have a xl.conf.5.pod which has no substitutions in, and I don't
> recall this changing. Perhaps a logical dependency earlier in the SUSE
> patch queue?
>
> I think this patch needs a {pod=>pod.in} rename as well, for it to apply
> to staging and work as intended.
I figured that as well.
Perhaps I missed the patch that did the renaming from Olaf.
Unfortunately I don't have the full xen-devel archive in my mailbox now.
Wei.
>
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5
2019-08-19 7:57 ` Olaf Hering
@ 2019-08-19 8:02 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2019-08-19 8:02 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel, Ian Jackson, Wei Liu
On Mon, Aug 19, 2019 at 09:57:17AM +0200, Olaf Hering wrote:
> Am Sun, 18 Aug 2019 18:20:26 +0100
> schrieb Wei Liu <wl@xen.org>:
>
> > This doesn't apply. There is no such file.
>
> My changes need to be applied in this order, some of them may apply in any order:
>
> 20190619120633.27466-1-olaf@aepfle.de
> 20190619121715.28532-1-olaf@aepfle.de
> 20190619123818.30747-1-olaf@aepfle.de
> 20190619130335.3458-1-olaf@aepfle.de
> 20190621092944.29241-1-olaf@aepfle.de
> 20190621093005.29329-1-olaf@aepfle.de
Thanks. I will take a look.
Wei.
>
>
> Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-08-19 8:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-21 9:30 [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5 Olaf Hering
2019-07-02 15:09 ` Anthony PERARD
2019-08-18 17:20 ` Wei Liu
2019-08-18 17:27 ` Andrew Cooper
2019-08-19 8:00 ` Wei Liu
2019-08-19 7:57 ` Olaf Hering
2019-08-19 8:02 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).