* [Xen-devel] [PATCH] drivers/acpi: Drop "ERST table was not found" message
@ 2019-09-13 16:20 Andrew Cooper
2019-09-16 7:35 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2019-09-13 16:20 UTC (permalink / raw)
To: Xen-devel; +Cc: Andrew Cooper, Jan Beulich
ERST isn't a mandatory table, and also isn't very common to find. The message
is unnecessary noise during boot. Furthermore, it is redundant with the list
of found ACPI tables printed just ahead.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
xen/drivers/acpi/apei/erst.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c
index 23a4e822e7..c5df512b98 100644
--- a/xen/drivers/acpi/apei/erst.c
+++ b/xen/drivers/acpi/apei/erst.c
@@ -791,10 +791,9 @@ int __init erst_init(void)
return -ENODEV;
status = acpi_get_table_phys(ACPI_SIG_ERST, 0, &erst_addr, &erst_len);
- if (status == AE_NOT_FOUND) {
- printk(KERN_INFO "ERST table was not found\n");
+ if (status == AE_NOT_FOUND)
return -ENODEV;
- }
+
if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
printk(KERN_WARNING "Failed to get ERST table: %s\n", msg);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Xen-devel] [PATCH] drivers/acpi: Drop "ERST table was not found" message
2019-09-13 16:20 [Xen-devel] [PATCH] drivers/acpi: Drop "ERST table was not found" message Andrew Cooper
@ 2019-09-16 7:35 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2019-09-16 7:35 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel
On 13.09.2019 18:20, Andrew Cooper wrote:
> ERST isn't a mandatory table, and also isn't very common to find. The message
> is unnecessary noise during boot. Furthermore, it is redundant with the list
> of found ACPI tables printed just ahead.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-16 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-13 16:20 [Xen-devel] [PATCH] drivers/acpi: Drop "ERST table was not found" message Andrew Cooper
2019-09-16 7:35 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).