* [Xen-devel] [PATCH] x86/shadow: use single (atomic) MOV for emulated writes
@ 2020-01-16 20:29 Jason Andryuk
2020-01-17 7:20 ` Tim Deegan
0 siblings, 1 reply; 2+ messages in thread
From: Jason Andryuk @ 2020-01-16 20:29 UTC (permalink / raw)
To: xen-devel
Cc: Wei Liu, Jason Andryuk, George Dunlap, Andrew Cooper, Tim Deegan,
Jan Beulich, Roger Pau Monné
This is the corresponding change to the shadow code as made by
bf08a8a08a2e "x86/HVM: use single (atomic) MOV for aligned emulated
writes" to the non-shadow HVM code.
The bf08a8a08a2e commit message:
Using memcpy() may result in multiple individual byte accesses
(depending how memcpy() is implemented and how the resulting insns,
e.g. REP MOVSB, get carried out in hardware), which isn't what we
want/need for carrying out guest insns as correctly as possible. Fall
back to memcpy() only for accesses not 2, 4, or 8 bytes in size.
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
xen/arch/x86/mm/shadow/hvm.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/xen/arch/x86/mm/shadow/hvm.c b/xen/arch/x86/mm/shadow/hvm.c
index 48dfad4557..a219266fa2 100644
--- a/xen/arch/x86/mm/shadow/hvm.c
+++ b/xen/arch/x86/mm/shadow/hvm.c
@@ -215,7 +215,15 @@ hvm_emulate_write(enum x86_segment seg,
return ~PTR_ERR(ptr);
paging_lock(v->domain);
- memcpy(ptr, p_data, bytes);
+
+ /* Where possible use single (and hence generally atomic) MOV insns. */
+ switch ( bytes )
+ {
+ case 2: write_u16_atomic(ptr, *(uint16_t *)p_data); break;
+ case 4: write_u32_atomic(ptr, *(uint32_t *)p_data); break;
+ case 8: write_u64_atomic(ptr, *(uint64_t *)p_data); break;
+ default: memcpy(ptr, p_data, bytes); break;
+ }
if ( tb_init_done )
v->arch.paging.mode->shadow.trace_emul_write_val(ptr, addr,
--
2.24.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Xen-devel] [PATCH] x86/shadow: use single (atomic) MOV for emulated writes
2020-01-16 20:29 [Xen-devel] [PATCH] x86/shadow: use single (atomic) MOV for emulated writes Jason Andryuk
@ 2020-01-17 7:20 ` Tim Deegan
0 siblings, 0 replies; 2+ messages in thread
From: Tim Deegan @ 2020-01-17 7:20 UTC (permalink / raw)
To: Jason Andryuk
Cc: Wei Liu, George Dunlap, Andrew Cooper, Jan Beulich, xen-devel,
Roger Pau Monné
At 15:29 -0500 on 16 Jan (1579188566), Jason Andryuk wrote:
> This is the corresponding change to the shadow code as made by
> bf08a8a08a2e "x86/HVM: use single (atomic) MOV for aligned emulated
> writes" to the non-shadow HVM code.
>
> The bf08a8a08a2e commit message:
> Using memcpy() may result in multiple individual byte accesses
> (depending how memcpy() is implemented and how the resulting insns,
> e.g. REP MOVSB, get carried out in hardware), which isn't what we
> want/need for carrying out guest insns as correctly as possible. Fall
> back to memcpy() only for accesses not 2, 4, or 8 bytes in size.
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Acked-by: Tim Deegan <tim@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-17 7:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 20:29 [Xen-devel] [PATCH] x86/shadow: use single (atomic) MOV for emulated writes Jason Andryuk
2020-01-17 7:20 ` Tim Deegan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).