* [Xen-devel] [PATCH] tools/xenstore: add newline for printing of stubdom console messages
@ 2020-01-31 14:25 Juergen Gross
2020-01-31 14:26 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2020-01-31 14:25 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Ian Jackson, Wei Liu
There are several places in xenstore-stubdom where newlines at the end
of messages on the console are missing. Add them.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libs/evtchn/minios.c | 1 +
tools/xenstore/xenstored_core.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c
index 414c21ba67..9cd7636fc5 100644
--- a/tools/libs/evtchn/minios.c
+++ b/tools/libs/evtchn/minios.c
@@ -218,6 +218,7 @@ xenevtchn_port_or_error_t xenevtchn_bind_virq(xenevtchn_handle *xce, unsigned in
printf("xenevtchn_bind_virq(%d)", virq);
port = bind_virq(virq, evtchn_handler, (void*)(intptr_t)fd);
+ printf(" = %d\n", port);
if (port < 0) {
port_dealloc(port_info);
diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 97ceabf964..551fe38f57 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -88,7 +88,7 @@ static const char *sockmsg_string(enum xsd_sockmsg_type type);
char *s = talloc_asprintf(NULL, __VA_ARGS__); \
if (s) { \
trace("%s\n", s); \
- syslog(LOG_ERR, "%s", s); \
+ syslog(LOG_ERR, "%s\n", s); \
talloc_free(s); \
} else { \
trace("talloc failure during logging\n"); \
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Xen-devel] [PATCH] tools/xenstore: add newline for printing of stubdom console messages
2020-01-31 14:25 [Xen-devel] [PATCH] tools/xenstore: add newline for printing of stubdom console messages Juergen Gross
@ 2020-01-31 14:26 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2020-01-31 14:26 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, Ian Jackson, Wei Liu
On Fri, Jan 31, 2020 at 03:25:09PM +0100, Juergen Gross wrote:
> There are several places in xenstore-stubdom where newlines at the end
> of messages on the console are missing. Add them.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wl@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-31 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 14:25 [Xen-devel] [PATCH] tools/xenstore: add newline for printing of stubdom console messages Juergen Gross
2020-01-31 14:26 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).