* [Xen-devel] [PATCH v1] libxl: Fix xl shutdown for HVM without PV drivers
@ 2020-03-18 16:51 Olaf Hering
2020-03-21 16:43 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2020-03-18 16:51 UTC (permalink / raw)
To: Ian Jackson, Wei Liu, Anthony PERARD, xen-devel; +Cc: Olaf Hering
A return value of zero means no PV drivers. Restore a hunk which was removed.
Fixes commit b183e180bce93037d3ef385a8c2338bbfb7f23d9
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/libxl/libxl_domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
index 41d08394f3..fef2cd4e13 100644
--- a/tools/libxl/libxl_domain.c
+++ b/tools/libxl/libxl_domain.c
@@ -774,6 +774,9 @@ int libxl__domain_pvcontrol(libxl__egc *egc, libxl__xswait_state *pvcontrol,
if (rc < 0)
return rc;
+ if (!rc)
+ return ERROR_NOPARAVIRT;
+
shutdown_path = libxl__domain_pvcontrol_xspath(gc, domid);
if (!shutdown_path)
return ERROR_FAIL;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Xen-devel] [PATCH v1] libxl: Fix xl shutdown for HVM without PV drivers
2020-03-18 16:51 [Xen-devel] [PATCH v1] libxl: Fix xl shutdown for HVM without PV drivers Olaf Hering
@ 2020-03-21 16:43 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2020-03-21 16:43 UTC (permalink / raw)
To: Olaf Hering; +Cc: Anthony PERARD, xen-devel, Ian Jackson, Wei Liu
On Wed, Mar 18, 2020 at 05:51:51PM +0100, Olaf Hering wrote:
> A return value of zero means no PV drivers. Restore a hunk which was removed.
>
> Fixes commit b183e180bce93037d3ef385a8c2338bbfb7f23d9
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Wei Liu <wl@xen.org>
And applied.
> ---
> tools/libxl/libxl_domain.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/libxl/libxl_domain.c b/tools/libxl/libxl_domain.c
> index 41d08394f3..fef2cd4e13 100644
> --- a/tools/libxl/libxl_domain.c
> +++ b/tools/libxl/libxl_domain.c
> @@ -774,6 +774,9 @@ int libxl__domain_pvcontrol(libxl__egc *egc, libxl__xswait_state *pvcontrol,
> if (rc < 0)
> return rc;
>
> + if (!rc)
> + return ERROR_NOPARAVIRT;
> +
> shutdown_path = libxl__domain_pvcontrol_xspath(gc, domid);
> if (!shutdown_path)
> return ERROR_FAIL;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-21 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 16:51 [Xen-devel] [PATCH v1] libxl: Fix xl shutdown for HVM without PV drivers Olaf Hering
2020-03-21 16:43 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).