* [PATCH] x86/boot: Don't disable PV32 when XEN_SHSTK is compiled out
@ 2020-06-29 10:31 Andrew Cooper
2020-06-29 11:28 ` Jan Beulich
2020-06-29 11:49 ` Paul Durrant
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2020-06-29 10:31 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Paul Durrant, Wei Liu, Jan Beulich, Roger Pau Monné
There is no need to automatically disable PV32 support on SHSTK-capable
hardware if Xen isn't actually using the feature.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Paul Durrant <paul@xen.org>
For 4.14. Minor bugfix.
---
xen/arch/x86/setup.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 2aa1cd50b8..c9b6af826d 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -95,7 +95,11 @@ unsigned long __initdata highmem_start;
size_param("highmem-start", highmem_start);
#endif
+#ifdef CONFIG_XEN_SHSTK
static bool __initdata opt_xen_shstk = true;
+#else
+#define opt_xen_shstk false
+#endif
static int __init parse_cet(const char *s)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/boot: Don't disable PV32 when XEN_SHSTK is compiled out
2020-06-29 10:31 [PATCH] x86/boot: Don't disable PV32 when XEN_SHSTK is compiled out Andrew Cooper
@ 2020-06-29 11:28 ` Jan Beulich
2020-06-29 11:49 ` Paul Durrant
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2020-06-29 11:28 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel, Paul Durrant, Wei Liu, Roger Pau Monné
On 29.06.2020 12:31, Andrew Cooper wrote:
> There is no need to automatically disable PV32 support on SHSTK-capable
> hardware if Xen isn't actually using the feature.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] x86/boot: Don't disable PV32 when XEN_SHSTK is compiled out
2020-06-29 10:31 [PATCH] x86/boot: Don't disable PV32 when XEN_SHSTK is compiled out Andrew Cooper
2020-06-29 11:28 ` Jan Beulich
@ 2020-06-29 11:49 ` Paul Durrant
1 sibling, 0 replies; 3+ messages in thread
From: Paul Durrant @ 2020-06-29 11:49 UTC (permalink / raw)
To: 'Andrew Cooper', 'Xen-devel'
Cc: 'Wei Liu', 'Jan Beulich', 'Roger Pau Monné'
> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@citrix.com>
> Sent: 29 June 2020 11:31
> To: Xen-devel <xen-devel@lists.xenproject.org>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>; Jan Beulich <JBeulich@suse.com>; Wei Liu <wl@xen.org>;
> Roger Pau Monné <roger.pau@citrix.com>; Paul Durrant <paul@xen.org>
> Subject: [PATCH] x86/boot: Don't disable PV32 when XEN_SHSTK is compiled out
>
> There is no need to automatically disable PV32 support on SHSTK-capable
> hardware if Xen isn't actually using the feature.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wl@xen.org>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Paul Durrant <paul@xen.org>
>
> For 4.14. Minor bugfix.
Release-acked-by: Paul Durrant <paul@xen.org>
> ---
> xen/arch/x86/setup.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
> index 2aa1cd50b8..c9b6af826d 100644
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -95,7 +95,11 @@ unsigned long __initdata highmem_start;
> size_param("highmem-start", highmem_start);
> #endif
>
> +#ifdef CONFIG_XEN_SHSTK
> static bool __initdata opt_xen_shstk = true;
> +#else
> +#define opt_xen_shstk false
> +#endif
>
> static int __init parse_cet(const char *s)
> {
> --
> 2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-29 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 10:31 [PATCH] x86/boot: Don't disable PV32 when XEN_SHSTK is compiled out Andrew Cooper
2020-06-29 11:28 ` Jan Beulich
2020-06-29 11:49 ` Paul Durrant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).