From: Roger Pau Monne <roger.pau@citrix.com>
To: <linux-kernel@vger.kernel.org>
Cc: "Roger Pau Monne" <roger.pau@citrix.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"SeongJae Park" <sjpark@amazon.de>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
"J . Roeleveld" <joost@antarean.org>,
"Jürgen Groß" <jgross@suse.com>
Subject: [PATCH 1/2] xen/blkback: turn the cache purge LRU interval into a parameter
Date: Thu, 15 Oct 2020 16:24:15 +0200 [thread overview]
Message-ID: <20201015142416.70294-2-roger.pau@citrix.com> (raw)
In-Reply-To: <20201015142416.70294-1-roger.pau@citrix.com>
Assume that reads and writes to the variable will be atomic. The worse
that could happen is that one of the LRU intervals is not calculated
properly if a partially written value is read, but that would only be
a transient issue.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: SeongJae Park <sjpark@amazon.de>
Cc: xen-devel@lists.xenproject.org
Cc: linux-block@vger.kernel.org
Cc: J. Roeleveld <joost@antarean.org>
Cc: Jürgen Groß <jgross@suse.com>
---
Documentation/ABI/testing/sysfs-driver-xen-blkback | 10 ++++++++++
drivers/block/xen-blkback/blkback.c | 9 ++++++---
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b/Documentation/ABI/testing/sysfs-driver-xen-blkback
index ecb7942ff146..776f25d335ca 100644
--- a/Documentation/ABI/testing/sysfs-driver-xen-blkback
+++ b/Documentation/ABI/testing/sysfs-driver-xen-blkback
@@ -35,3 +35,13 @@ Description:
controls the duration in milliseconds that blkback will not
cache any page not backed by a grant mapping.
The default is 10ms.
+
+What: /sys/module/xen_blkback/parameters/lru_internval
+Date: October 2020
+KernelVersion: 5.10
+Contact: Roger Pau Monné <roger.pau@citrix.com>
+Description:
+ The LRU mechanism to clean the lists of persistent grants needs
+ to be executed periodically. This parameter controls the time
+ interval between consecutive executions of the purge mechanism
+ is set in ms.
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index adfc9352351d..6ad9b76fdb2b 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -117,7 +117,10 @@ MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used for the
* be executed periodically. The time interval between consecutive executions
* of the purge mechanism is set in ms.
*/
-#define LRU_INTERVAL 100
+static unsigned int lru_interval = 100;
+module_param_named(lru_interval, lru_interval, uint, 0644);
+MODULE_PARM_DESC(lru_internval,
+ "Time interval between consecutive executions of the cache purge mechanism (in ms)");
/*
* When the persistent grants list is full we will remove unused grants
@@ -620,7 +623,7 @@ int xen_blkif_schedule(void *arg)
if (unlikely(vbd->size != vbd_sz(vbd)))
xen_vbd_resize(blkif);
- timeout = msecs_to_jiffies(LRU_INTERVAL);
+ timeout = msecs_to_jiffies(lru_interval);
timeout = wait_event_interruptible_timeout(
ring->wq,
@@ -650,7 +653,7 @@ int xen_blkif_schedule(void *arg)
if (blkif->vbd.feature_gnt_persistent &&
time_after(jiffies, ring->next_lru)) {
purge_persistent_gnt(ring);
- ring->next_lru = jiffies + msecs_to_jiffies(LRU_INTERVAL);
+ ring->next_lru = jiffies + msecs_to_jiffies(lru_interval);
}
/* Shrink the free pages pool if it is too large. */
--
2.28.0
next prev parent reply other threads:[~2020-10-15 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 14:24 [PATCH 0/2] xen/blkback: add LRU purge parameters Roger Pau Monne
2020-10-15 14:24 ` Roger Pau Monne [this message]
2020-10-15 14:30 ` [PATCH 1/2] xen/blkback: turn the cache purge LRU interval into a parameter Jürgen Groß
2020-10-15 15:08 ` SeongJae Park
2020-10-15 14:24 ` [PATCH 2/2] xen/blkback: turn the cache purge percent " Roger Pau Monne
2020-10-15 14:37 ` Jürgen Groß
2020-10-15 14:44 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015142416.70294-2-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=joost@antarean.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjpark@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).