From: SeongJae Park <sjpark@amazon.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: linux-kernel@vger.kernel.org,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"SeongJae Park" <sjpark@amazon.de>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
"J . Roeleveld" <joost@antarean.org>,
"Jürgen Groß" <jgross@suse.com>
Subject: Re: [PATCH 1/2] xen/blkback: turn the cache purge LRU interval into a parameter
Date: Thu, 15 Oct 2020 17:08:49 +0200 [thread overview]
Message-ID: <20201015150849.3844-1-sjpark@amazon.com> (raw)
In-Reply-To: <20201015142416.70294-2-roger.pau@citrix.com>
On Thu, 15 Oct 2020 16:24:15 +0200 Roger Pau Monne <roger.pau@citrix.com> wrote:
> Assume that reads and writes to the variable will be atomic. The worse
> that could happen is that one of the LRU intervals is not calculated
> properly if a partially written value is read, but that would only be
> a transient issue.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: SeongJae Park <sjpark@amazon.de>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-block@vger.kernel.org
> Cc: J. Roeleveld <joost@antarean.org>
> Cc: Jürgen Groß <jgross@suse.com>
> ---
> Documentation/ABI/testing/sysfs-driver-xen-blkback | 10 ++++++++++
> drivers/block/xen-blkback/blkback.c | 9 ++++++---
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b/Documentation/ABI/testing/sysfs-driver-xen-blkback
> index ecb7942ff146..776f25d335ca 100644
> --- a/Documentation/ABI/testing/sysfs-driver-xen-blkback
> +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkback
> @@ -35,3 +35,13 @@ Description:
> controls the duration in milliseconds that blkback will not
> cache any page not backed by a grant mapping.
> The default is 10ms.
> +
> +What: /sys/module/xen_blkback/parameters/lru_internval
> +Date: October 2020
> +KernelVersion: 5.10
> +Contact: Roger Pau Monné <roger.pau@citrix.com>
> +Description:
> + The LRU mechanism to clean the lists of persistent grants needs
> + to be executed periodically. This parameter controls the time
> + interval between consecutive executions of the purge mechanism
> + is set in ms.
I think noticing the default value (100ms) here would be better.
Thanks,
SeongJae Park
next prev parent reply other threads:[~2020-10-15 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 14:24 [PATCH 0/2] xen/blkback: add LRU purge parameters Roger Pau Monne
2020-10-15 14:24 ` [PATCH 1/2] xen/blkback: turn the cache purge LRU interval into a parameter Roger Pau Monne
2020-10-15 14:30 ` Jürgen Groß
2020-10-15 15:08 ` SeongJae Park [this message]
2020-10-15 14:24 ` [PATCH 2/2] xen/blkback: turn the cache purge percent " Roger Pau Monne
2020-10-15 14:37 ` Jürgen Groß
2020-10-15 14:44 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015150849.3844-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=joost@antarean.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=sjpark@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).