* flawed Makefile dependencies in libacpi
@ 2020-10-27 9:45 Olaf Hering
2020-10-27 10:18 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2020-10-27 9:45 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
Every once in a while build.c fails to compile because ssdt_s3.h does not exist. The 'sed' command which creates the file appears a few lines down in the build log.
I'm not familiar with make. I wonder if "build.o" should depend on "$(H_SRC)" instead of the expanded list of generated headers. Some sort of dependency to the individual files seem to exist, otherwise make would probably complain.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: flawed Makefile dependencies in libacpi
2020-10-27 9:45 flawed Makefile dependencies in libacpi Olaf Hering
@ 2020-10-27 10:18 ` Jan Beulich
2020-10-27 10:25 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2020-10-27 10:18 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
On 27.10.2020 10:45, Olaf Hering wrote:
> Every once in a while build.c fails to compile because ssdt_s3.h does not exist. The 'sed' command which creates the file appears a few lines down in the build log.
>
> I'm not familiar with make. I wonder if "build.o" should depend on "$(H_SRC)" instead of the expanded list of generated headers.
Oh, yes, it definitely should. Will you make a patch?
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: flawed Makefile dependencies in libacpi
2020-10-27 10:18 ` Jan Beulich
@ 2020-10-27 10:25 ` Jan Beulich
2020-10-27 10:30 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2020-10-27 10:25 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
On 27.10.2020 11:18, Jan Beulich wrote:
> On 27.10.2020 10:45, Olaf Hering wrote:
>> Every once in a while build.c fails to compile because ssdt_s3.h does not exist. The 'sed' command which creates the file appears a few lines down in the build log.
>>
>> I'm not familiar with make. I wonder if "build.o" should depend on "$(H_SRC)" instead of the expanded list of generated headers.
>
> Oh, yes, it definitely should. Will you make a patch?
Actually it only should be if this line was useful for anything.
But it's dead. Instead the consumers of libacpi/ may need
respective dependencies to be added. In this context it then is
relevant in which context you see the failure - firmware/hvmloader/
or libs/light/ ?
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: flawed Makefile dependencies in libacpi
2020-10-27 10:25 ` Jan Beulich
@ 2020-10-27 10:30 ` Olaf Hering
2020-10-27 10:38 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2020-10-27 10:30 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
Am Tue, 27 Oct 2020 11:25:17 +0100
schrieb Jan Beulich <jbeulich@suse.com>:
> In this context it then is relevant in which context you see the failure - firmware/hvmloader/ or libs/light/ ?
I do not have the log anymore to check this detail.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: flawed Makefile dependencies in libacpi
2020-10-27 10:30 ` Olaf Hering
@ 2020-10-27 10:38 ` Jan Beulich
2020-10-27 10:42 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2020-10-27 10:38 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
On 27.10.2020 11:30, Olaf Hering wrote:
> Am Tue, 27 Oct 2020 11:25:17 +0100
> schrieb Jan Beulich <jbeulich@suse.com>:
>
>> In this context it then is relevant in which context you see the failure - firmware/hvmloader/ or libs/light/ ?
>
> I do not have the log anymore to check this detail.
From looking at both makefiles, it's only libxl which is affected.
I guess I'll make a patch then.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: flawed Makefile dependencies in libacpi
2020-10-27 10:38 ` Jan Beulich
@ 2020-10-27 10:42 ` Olaf Hering
0 siblings, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2020-10-27 10:42 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
Am Tue, 27 Oct 2020 11:38:04 +0100
schrieb Jan Beulich <jbeulich@suse.com>:
> I guess I'll make a patch then.
Thanks. I briefly looked at the code and it is not obvious how it would need to look like.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-27 10:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 9:45 flawed Makefile dependencies in libacpi Olaf Hering
2020-10-27 10:18 ` Jan Beulich
2020-10-27 10:25 ` Jan Beulich
2020-10-27 10:30 ` Olaf Hering
2020-10-27 10:38 ` Jan Beulich
2020-10-27 10:42 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).