* [PULL 4/9] include/hw/xen.h: drop superfluous struct
[not found] <20201116122417.28346-1-alex.bennee@linaro.org>
@ 2020-11-16 12:24 ` Alex Bennée
2020-11-16 12:24 ` [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub Alex Bennée
1 sibling, 0 replies; 2+ messages in thread
From: Alex Bennée @ 2020-11-16 12:24 UTC (permalink / raw)
To: peter.maydell
Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé,
Stefano Stabellini, Anthony Perard, Paul Durrant,
open list:X86 Xen CPUs
Chardev is already a typedef'ed struct.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201110192316.26397-5-alex.bennee@linaro.org>
diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
index 1406648ca5..0f9962b1c1 100644
--- a/include/hw/xen/xen.h
+++ b/include/hw/xen/xen.h
@@ -28,7 +28,7 @@ int xen_is_pirq_msi(uint32_t msi_data);
qemu_irq *xen_interrupt_controller_init(void);
-void xenstore_store_pv_console_info(int i, struct Chardev *chr);
+void xenstore_store_pv_console_info(int i, Chardev *chr);
void xen_register_framebuffer(struct MemoryRegion *mr);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub
[not found] <20201116122417.28346-1-alex.bennee@linaro.org>
2020-11-16 12:24 ` [PULL 4/9] include/hw/xen.h: drop superfluous struct Alex Bennée
@ 2020-11-16 12:24 ` Alex Bennée
1 sibling, 0 replies; 2+ messages in thread
From: Alex Bennée @ 2020-11-16 12:24 UTC (permalink / raw)
To: peter.maydell
Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé,
Stefano Stabellini, Anthony Perard, Paul Durrant, Paolo Bonzini,
open list:X86 Xen CPUs
We should never build something that calls this without having it.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201110192316.26397-6-alex.bennee@linaro.org>
diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c
index 2ea8190921..15f3921a76 100644
--- a/stubs/xen-hw-stub.c
+++ b/stubs/xen-hw-stub.c
@@ -10,10 +10,6 @@
#include "hw/xen/xen.h"
#include "hw/xen/xen-x86.h"
-void xenstore_store_pv_console_info(int i, Chardev *chr)
-{
-}
-
int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num)
{
return -1;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201116122417.28346-1-alex.bennee@linaro.org>
2020-11-16 12:24 ` [PULL 4/9] include/hw/xen.h: drop superfluous struct Alex Bennée
2020-11-16 12:24 ` [PULL 5/9] stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).