From: Manuel Bouyer <bouyer@antioche.eu.org>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org
Subject: Re: NetBSD dom0 PVH: hardware interrupts stalls
Date: Mon, 23 Nov 2020 12:32:41 +0100 [thread overview]
Message-ID: <20201123113241.GE2520@antioche.eu.org> (raw)
In-Reply-To: <20201123095713.orfpg72r73m7f46n@Air-de-Roger>
On Mon, Nov 23, 2020 at 10:57:13AM +0100, Roger Pau Monné wrote:
> > [...]
> > OK.
> > I finally found where the EOI occurs (it's within a macro so s simple grep
> > didn't show it).
> >
> > When interrupts are not masked (e.g. via cli), the ioapic halder is called.
> > From here, 2 paths can happen:
> > a) the software interrupt priority level (called spl in BSD world) allows the
> > driver's handler to run. In this case it's called, then the interrupt
> > is unmasked at ioapic level, and EOI'd at lapic.
> > b) the software interrupt priority level doesn't allow this driver's handler to
> > run. In this case, the interrupt is marked as pending in software,
> > explicitely masked at the iopic level and EOI'd at lapic.
> > Later, when the spl is lowered, the driver's interrupt handler is run,
> > then the interrupt is unmasked at ioapic level, and EOI'd at lapic
> > (this is the same path as a)). here we may EOI the lapic twice, and the
> > second time when there's no hardware interrupt pending any more.
> >
> > I suspect it's case b) which causes the problem with Xen.
>
> Case b) should be handled fine AFAICT. If there's no interrupt pending
> in the lapic ISR the EOI is just a noop. Iff there's somehow another
> vector pending in ISR you might actually be EOIing the wrong vector,
> and thus this would be a bug in NetBSD. I certainly don't know much of
> NetBSD interrupt model in order to know whether this second EOI is just
> not necessary or whether it could cause issues.
>
> Can you actually assert that disabling this second unneeded EOI does
> solve the problem?
I tried this, and it didn't change anything ...
I'm out of idea to try.
--
Manuel Bouyer <bouyer@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--
next prev parent reply other threads:[~2020-11-23 11:33 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 15:09 NetBSD dom0 PVH: hardware interrupts stalls Manuel Bouyer
2020-11-17 15:58 ` Roger Pau Monné
2020-11-17 16:40 ` Manuel Bouyer
2020-11-18 8:57 ` Roger Pau Monné
2020-11-18 9:24 ` Manuel Bouyer
2020-11-18 10:00 ` Roger Pau Monné
2020-11-18 12:14 ` Manuel Bouyer
2020-11-18 14:39 ` Roger Pau Monné
2020-11-18 14:59 ` Jan Beulich
2020-11-19 14:19 ` Roger Pau Monné
2020-11-19 15:57 ` Manuel Bouyer
2020-11-19 16:57 ` Manuel Bouyer
2020-11-19 17:57 ` Manuel Bouyer
2020-11-20 8:09 ` Jan Beulich
2020-11-20 8:28 ` Roger Pau Monné
2020-11-20 8:52 ` Manuel Bouyer
2020-11-20 8:59 ` Jan Beulich
2020-11-20 9:27 ` Manuel Bouyer
2020-11-20 10:00 ` Jan Beulich
2020-11-20 10:38 ` Manuel Bouyer
2020-11-23 9:57 ` Roger Pau Monné
2020-11-23 11:32 ` Manuel Bouyer [this message]
2020-11-23 12:51 ` Roger Pau Monné
2020-11-23 14:31 ` Manuel Bouyer
2020-11-23 17:06 ` Roger Pau Monné
2020-11-23 17:39 ` Manuel Bouyer
2020-11-24 10:05 ` Jan Beulich
2020-11-24 12:21 ` Roger Pau Monné
2020-11-24 13:59 ` Manuel Bouyer
2020-11-24 14:09 ` Jan Beulich
2020-11-24 14:27 ` Manuel Bouyer
2020-11-24 14:33 ` Jan Beulich
2020-11-24 14:36 ` Jan Beulich
2020-11-24 14:52 ` Jan Beulich
2020-11-24 15:00 ` Roger Pau Monné
2020-11-24 15:08 ` Manuel Bouyer
2020-11-24 15:49 ` Roger Pau Monné
2020-11-24 16:09 ` Manuel Bouyer
2020-11-26 13:34 ` Roger Pau Monné
2020-11-26 14:16 ` Manuel Bouyer
2020-11-26 14:26 ` Roger Pau Monné
2020-11-26 15:09 ` Roger Pau Monné
2020-11-26 17:20 ` Manuel Bouyer
2020-11-27 10:59 ` Roger Pau Monné
2020-11-27 11:18 ` Jan Beulich
2020-11-27 11:19 ` Manuel Bouyer
2020-11-27 11:21 ` Jan Beulich
2020-11-27 13:10 ` Manuel Bouyer
2020-11-27 13:14 ` Jan Beulich
2020-11-27 13:18 ` Manuel Bouyer
2020-11-27 11:29 ` Jan Beulich
2020-11-27 13:13 ` Manuel Bouyer
2020-11-27 13:18 ` Jan Beulich
2020-11-27 13:31 ` Manuel Bouyer
2020-11-27 13:40 ` Jan Beulich
2020-11-27 13:49 ` Jürgen Groß
2020-11-27 13:59 ` Manuel Bouyer
2020-11-27 20:22 ` Roger Pau Monné
2020-11-27 21:44 ` Manuel Bouyer
2020-11-28 14:53 ` Roger Pau Monné
2020-11-28 17:14 ` Manuel Bouyer
2020-11-29 9:23 ` Manuel Bouyer
2020-11-30 10:00 ` Jan Beulich
2020-11-30 10:28 ` Manuel Bouyer
2020-11-30 11:35 ` Manuel Bouyer
2020-11-30 11:44 ` Jan Beulich
2020-11-30 11:50 ` Manuel Bouyer
2020-11-30 12:09 ` Jan Beulich
2020-11-24 14:42 ` Jan Beulich
2020-11-24 14:59 ` Roger Pau Monné
2020-11-24 15:18 ` Manuel Bouyer
2020-11-24 15:23 ` Jürgen Groß
2020-11-20 8:54 ` Jan Beulich
2020-11-20 9:13 ` Manuel Bouyer
2020-11-23 9:49 ` Roger Pau Monné
2020-11-18 15:03 ` Manuel Bouyer
2020-11-18 9:16 ` Jan Beulich
2020-11-18 9:28 ` Manuel Bouyer
2020-11-18 9:43 ` Jan Beulich
2020-11-18 10:14 ` Manuel Bouyer
2020-11-18 11:17 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201123113241.GE2520@antioche.eu.org \
--to=bouyer@antioche.eu.org \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).