* [PATCH] x86/xen: Fix compilation error due to missing nopvspin declaration
@ 2021-01-20 14:43 Leon Romanovsky
2021-01-20 14:47 ` Jürgen Groß
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2021-01-20 14:43 UTC (permalink / raw)
To: David Woodhouse, Juergen Gross
Cc: Leon Romanovsky, Stefano Stabellini, Boris Ostrovsky, xen-devel
From: Leon Romanovsky <leonro@nvidia.com>
arch/x86/xen/smp_hvm.c: In function 'xen_hvm_smp_init':
arch/x86/xen/smp_hvm.c:77:3: error: 'nopvspin' undeclared (first use in this function)
nopvspin = true;
^~~~~~~~
arch/x86/xen/smp_hvm.c:77:3: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [scripts/Makefile.build:279: arch/x86/xen/smp_hvm.o] Error 1
make[3]: *** [scripts/Makefile.build:496: arch/x86/xen] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1805: arch/x86] Error 2
make[2]: *** Waiting for unfinished jobs....
Fixes: 3d7746bea925 ("x86/xen: Fix xen_hvm_smp_init() when vector callback not available")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
arch/x86/xen/smp_hvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c
index 056430a1080b..1656713db71c 100644
--- a/arch/x86/xen/smp_hvm.c
+++ b/arch/x86/xen/smp_hvm.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#include <linux/thread_info.h>
#include <asm/smp.h>
+#include <asm/qspinlock.h>
#include <xen/events.h>
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/xen: Fix compilation error due to missing nopvspin declaration
2021-01-20 14:43 [PATCH] x86/xen: Fix compilation error due to missing nopvspin declaration Leon Romanovsky
@ 2021-01-20 14:47 ` Jürgen Groß
2021-01-20 14:56 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: Jürgen Groß @ 2021-01-20 14:47 UTC (permalink / raw)
To: Leon Romanovsky, David Woodhouse
Cc: Leon Romanovsky, Stefano Stabellini, Boris Ostrovsky, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 923 bytes --]
On 20.01.21 15:43, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> arch/x86/xen/smp_hvm.c: In function 'xen_hvm_smp_init':
> arch/x86/xen/smp_hvm.c:77:3: error: 'nopvspin' undeclared (first use in this function)
> nopvspin = true;
> ^~~~~~~~
> arch/x86/xen/smp_hvm.c:77:3: note: each undeclared identifier is reported only once for each function it appears in
> make[4]: *** [scripts/Makefile.build:279: arch/x86/xen/smp_hvm.o] Error 1
> make[3]: *** [scripts/Makefile.build:496: arch/x86/xen] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile:1805: arch/x86] Error 2
> make[2]: *** Waiting for unfinished jobs....
>
> Fixes: 3d7746bea925 ("x86/xen: Fix xen_hvm_smp_init() when vector callback not available")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
There is already a fix queued in the xen tree.
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/xen: Fix compilation error due to missing nopvspin declaration
2021-01-20 14:47 ` Jürgen Groß
@ 2021-01-20 14:56 ` Leon Romanovsky
0 siblings, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2021-01-20 14:56 UTC (permalink / raw)
To: Jürgen Groß
Cc: David Woodhouse, Stefano Stabellini, Boris Ostrovsky, xen-devel
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
On Wed, Jan 20, 2021 at 03:47:00PM +0100, Jürgen Groß wrote:
> On 20.01.21 15:43, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > arch/x86/xen/smp_hvm.c: In function 'xen_hvm_smp_init':
> > arch/x86/xen/smp_hvm.c:77:3: error: 'nopvspin' undeclared (first use in this function)
> > nopvspin = true;
> > ^~~~~~~~
> > arch/x86/xen/smp_hvm.c:77:3: note: each undeclared identifier is reported only once for each function it appears in
> > make[4]: *** [scripts/Makefile.build:279: arch/x86/xen/smp_hvm.o] Error 1
> > make[3]: *** [scripts/Makefile.build:496: arch/x86/xen] Error 2
> > make[3]: *** Waiting for unfinished jobs....
> > make[2]: *** [Makefile:1805: arch/x86] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >
> > Fixes: 3d7746bea925 ("x86/xen: Fix xen_hvm_smp_init() when vector callback not available")
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>
> There is already a fix queued in the xen tree.
Glad to hear, it is unfortunate that the problematic commit already in Linus tree.
Thanks
>
>
> Juergen
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-20 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 14:43 [PATCH] x86/xen: Fix compilation error due to missing nopvspin declaration Leon Romanovsky
2021-01-20 14:47 ` Jürgen Groß
2021-01-20 14:56 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).