From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: raphning@amazon.co.uk, iwj@xenproject.org,
Julien Grall <jgrall@amazon.com>
Subject: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters
Date: Fri, 5 Mar 2021 12:10:29 +0000 [thread overview]
Message-ID: <20210305121029.7047-1-julien@xen.org> (raw)
From: Julien Grall <jgrall@amazon.com>
The longest possible command line for LiveUpdate is:
liveupdate -s -t <timeout> -F
This is 5 parameters. However, the maximum is currently specified to 4.
This means the some of the parameters will get ignored.
Update the field max_pars to 5 so and admin can specify the timeout and
force at the same time.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
This is a candidate for Xen 4.15. Without it, it would not be possible
to pass -F and -t together.
The change is only modifying behavior for XenStored LiveUpdate.
---
tools/xenstore/xenstored_control.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c
index a1652219b247..8e470f2b2056 100644
--- a/tools/xenstore/xenstored_control.c
+++ b/tools/xenstore/xenstored_control.c
@@ -768,7 +768,7 @@ static struct cmd_s cmds[] = {
*/
{ "live-update", do_control_lu,
"[-c <cmdline>] [-F] [-t <timeout>] <file>\n"
- " Default timeout is 60 seconds.", 4 },
+ " Default timeout is 60 seconds.", 5 },
#endif
#ifdef __MINIOS__
{ "memreport", do_control_memreport, "" },
--
2.17.1
next reply other threads:[~2021-03-05 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:10 Julien Grall [this message]
2021-03-05 12:44 ` [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters Jürgen Groß
2021-03-05 13:22 ` Ian Jackson
2021-03-05 14:33 ` Jürgen Groß
2021-03-05 14:37 ` Ian Jackson
2021-03-05 14:41 ` Jürgen Groß
2021-03-05 14:46 ` Ian Jackson
2021-03-05 14:49 ` Ian Jackson
2021-03-05 14:55 ` Jürgen Groß
2021-03-05 14:56 ` Jürgen Groß
2021-03-06 19:39 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305121029.7047-1-julien@xen.org \
--to=julien@xen.org \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.com \
--cc=raphning@amazon.co.uk \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).