From: "Jürgen Groß" <jgross@suse.com>
To: Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org, raphning@amazon.co.uk,
Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters
Date: Fri, 5 Mar 2021 15:33:48 +0100 [thread overview]
Message-ID: <eb65580f-0b6b-717c-f599-73dc32d790cf@suse.com> (raw)
In-Reply-To: <24642.12417.651929.972294@mariner.uk.xensource.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 989 bytes --]
On 05.03.21 14:22, Ian Jackson wrote:
> Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters"):
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The longest possible command line for LiveUpdate is:
>>
>> liveupdate -s -t <timeout> -F
>>
>> This is 5 parameters. However, the maximum is currently specified to 4.
>> This means the some of the parameters will get ignored.
>
> Why are the extra parameters ignored rather than treated as errors ?
> This seems like an invitation to making code with bad behaviour
> (perhaps bad security-relevant behaviour).
>
> CC Juergen who seems to have written the code...
This is the max number of 0 delimited string parameters. Especially the
stubdom case needs a binary blob (with length, of course) as parameter,
and the number of 0 bytes in this data is just limited by the allowed
payload length.
See the comment in line 111 of xenstored_control.c.
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-03-05 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:10 [PATCH for-4.15] tools/xenstored: liveupdate: Increase the maximum number of parameters Julien Grall
2021-03-05 12:44 ` Jürgen Groß
2021-03-05 13:22 ` Ian Jackson
2021-03-05 14:33 ` Jürgen Groß [this message]
2021-03-05 14:37 ` Ian Jackson
2021-03-05 14:41 ` Jürgen Groß
2021-03-05 14:46 ` Ian Jackson
2021-03-05 14:49 ` Ian Jackson
2021-03-05 14:55 ` Jürgen Groß
2021-03-05 14:56 ` Jürgen Groß
2021-03-06 19:39 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb65580f-0b6b-717c-f599-73dc32d790cf@suse.com \
--to=jgross@suse.com \
--cc=iwj@xenproject.org \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=raphning@amazon.co.uk \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).