* [PATCH] kexec-xen: Use correct image type for Live Update
@ 2021-03-23 17:59 Raphael Ning
2021-04-02 10:01 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Raphael Ning @ 2021-03-23 17:59 UTC (permalink / raw)
To: Simon Horman
Cc: kexec, Raphael Ning, Julien Grall, Hongyan Xia, xen-devel, Raphael Ning
From: Raphael Ning <raphning@amazon.com>
Unlike xen_kexec_load(), xen_kexec_unload() and xen_kexec_status()
fail to distinguish between normal kexec and Xen Live Update image
types.
Fix that by introducing a new helper function that maps internal
flags to KEXEC_TYPE_*, and using it throughout kexec-xen.c.
Signed-off-by: Raphael Ning <raphning@amazon.com>
---
kexec/kexec-xen.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/kexec/kexec-xen.c b/kexec/kexec-xen.c
index da514d052e3d..47da3da466f0 100644
--- a/kexec/kexec-xen.c
+++ b/kexec/kexec-xen.c
@@ -91,6 +91,17 @@ out:
return rc;
}
+static uint8_t xen_get_kexec_type(unsigned long kexec_flags)
+{
+ if (kexec_flags & KEXEC_ON_CRASH)
+ return KEXEC_TYPE_CRASH;
+
+ if (kexec_flags & KEXEC_LIVE_UPDATE)
+ return KEXEC_TYPE_LIVE_UPDATE;
+
+ return KEXEC_TYPE_DEFAULT;
+}
+
#define IDENTMAP_1MiB (1024 * 1024)
int xen_kexec_load(struct kexec_info *info)
@@ -177,12 +188,7 @@ int xen_kexec_load(struct kexec_info *info)
seg++;
}
- if (info->kexec_flags & KEXEC_ON_CRASH)
- type = KEXEC_TYPE_CRASH;
- else if (info->kexec_flags & KEXEC_LIVE_UPDATE )
- type = KEXEC_TYPE_LIVE_UPDATE;
- else
- type = KEXEC_TYPE_DEFAULT;
+ type = xen_get_kexec_type(info->kexec_flags);
arch = (info->kexec_flags & KEXEC_ARCH_MASK) >> 16;
#if defined(__i386__) || defined(__x86_64__)
@@ -211,8 +217,7 @@ int xen_kexec_unload(uint64_t kexec_flags)
if (!xch)
return -1;
- type = (kexec_flags & KEXEC_ON_CRASH) ? KEXEC_TYPE_CRASH
- : KEXEC_TYPE_DEFAULT;
+ type = xen_get_kexec_type(kexec_flags);
ret = xc_kexec_unload(xch, type);
@@ -232,7 +237,7 @@ int xen_kexec_status(uint64_t kexec_flags)
if (!xch)
return -1;
- type = (kexec_flags & KEXEC_ON_CRASH) ? KEXEC_TYPE_CRASH : KEXEC_TYPE_DEFAULT;
+ type = xen_get_kexec_type(kexec_flags);
ret = xc_kexec_status(xch, type);
--
2.23.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kexec-xen: Use correct image type for Live Update
2021-03-23 17:59 [PATCH] kexec-xen: Use correct image type for Live Update Raphael Ning
@ 2021-04-02 10:01 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2021-04-02 10:01 UTC (permalink / raw)
To: Raphael Ning; +Cc: kexec, Julien Grall, Hongyan Xia, xen-devel, Raphael Ning
On Tue, Mar 23, 2021 at 05:59:23PM +0000, Raphael Ning wrote:
> From: Raphael Ning <raphning@amazon.com>
>
> Unlike xen_kexec_load(), xen_kexec_unload() and xen_kexec_status()
> fail to distinguish between normal kexec and Xen Live Update image
> types.
>
> Fix that by introducing a new helper function that maps internal
> flags to KEXEC_TYPE_*, and using it throughout kexec-xen.c.
>
> Signed-off-by: Raphael Ning <raphning@amazon.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-02 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 17:59 [PATCH] kexec-xen: Use correct image type for Live Update Raphael Ning
2021-04-02 10:01 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).