From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bobby Eshleman <bobby.eshleman@gmail.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: [PATCH v4 2/4] xen/riscv: introduce sbi call to putchar to console
Date: Thu, 19 Jan 2023 14:45:15 +0200 [thread overview]
Message-ID: <06ad9f6c8cbc87284ef4ecd4b85d9c7df33bd2c1.1673877778.git.oleksii.kurochko@gmail.com> (raw)
Message-ID: <20230119124515.qbZvI7Wvi3wkaNoTxGAh9AODf8u7vOFyH8EKSO6MjRw@z> (raw)
In-Reply-To: <cover.1673877778.git.oleksii.kurochko@gmail.com>
From: Bobby Eshleman <bobby.eshleman@gmail.com>
Originally SBI implementation for Xen was introduced by
Bobby Eshleman <bobby.eshleman@gmail.com> but it was removed
all the stuff for simplicity except SBI call for putting
character to console.
The patch introduces sbi_putchar() SBI call which is necessary
to implement initial early_printk.
Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
Changes in V4:
- Nothing changed
---
Changes in V3:
- update copyright's year
- rename definition of __CPU_SBI_H__ to __ASM_RISCV_SBI_H__
- fix identations
- change an author of the commit
---
Changes in V2:
- add an explanatory comment about sbi_console_putchar() function.
- order the files alphabetically in Makefile
---
xen/arch/riscv/Makefile | 1 +
xen/arch/riscv/include/asm/sbi.h | 34 ++++++++++++++++++++++++
xen/arch/riscv/sbi.c | 45 ++++++++++++++++++++++++++++++++
3 files changed, 80 insertions(+)
create mode 100644 xen/arch/riscv/include/asm/sbi.h
create mode 100644 xen/arch/riscv/sbi.c
diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile
index 5a67a3f493..fd916e1004 100644
--- a/xen/arch/riscv/Makefile
+++ b/xen/arch/riscv/Makefile
@@ -1,4 +1,5 @@
obj-$(CONFIG_RISCV_64) += riscv64/
+obj-y += sbi.o
obj-y += setup.o
$(TARGET): $(TARGET)-syms
diff --git a/xen/arch/riscv/include/asm/sbi.h b/xen/arch/riscv/include/asm/sbi.h
new file mode 100644
index 0000000000..0e6820a4ed
--- /dev/null
+++ b/xen/arch/riscv/include/asm/sbi.h
@@ -0,0 +1,34 @@
+/* SPDX-License-Identifier: (GPL-2.0-or-later) */
+/*
+ * Copyright (c) 2021-2023 Vates SAS.
+ *
+ * Taken from xvisor, modified by Bobby Eshleman (bobby.eshleman@gmail.com).
+ *
+ * Taken/modified from Xvisor project with the following copyright:
+ *
+ * Copyright (c) 2019 Western Digital Corporation or its affiliates.
+ */
+
+#ifndef __ASM_RISCV_SBI_H__
+#define __ASM_RISCV_SBI_H__
+
+#define SBI_EXT_0_1_CONSOLE_PUTCHAR 0x1
+
+struct sbiret {
+ long error;
+ long value;
+};
+
+struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
+ unsigned long arg0, unsigned long arg1,
+ unsigned long arg2, unsigned long arg3,
+ unsigned long arg4, unsigned long arg5);
+
+/**
+ * Writes given character to the console device.
+ *
+ * @param ch The data to be written to the console.
+ */
+void sbi_console_putchar(int ch);
+
+#endif /* __ASM_RISCV_SBI_H__ */
diff --git a/xen/arch/riscv/sbi.c b/xen/arch/riscv/sbi.c
new file mode 100644
index 0000000000..dc0eb44bc6
--- /dev/null
+++ b/xen/arch/riscv/sbi.c
@@ -0,0 +1,45 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Taken and modified from the xvisor project with the copyright Copyright (c)
+ * 2019 Western Digital Corporation or its affiliates and author Anup Patel
+ * (anup.patel@wdc.com).
+ *
+ * Modified by Bobby Eshleman (bobby.eshleman@gmail.com).
+ *
+ * Copyright (c) 2019 Western Digital Corporation or its affiliates.
+ * Copyright (c) 2021-2023 Vates SAS.
+ */
+
+#include <xen/errno.h>
+#include <asm/sbi.h>
+
+struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
+ unsigned long arg0, unsigned long arg1,
+ unsigned long arg2, unsigned long arg3,
+ unsigned long arg4, unsigned long arg5)
+{
+ struct sbiret ret;
+
+ register unsigned long a0 asm ("a0") = arg0;
+ register unsigned long a1 asm ("a1") = arg1;
+ register unsigned long a2 asm ("a2") = arg2;
+ register unsigned long a3 asm ("a3") = arg3;
+ register unsigned long a4 asm ("a4") = arg4;
+ register unsigned long a5 asm ("a5") = arg5;
+ register unsigned long a6 asm ("a6") = fid;
+ register unsigned long a7 asm ("a7") = ext;
+
+ asm volatile ("ecall"
+ : "+r" (a0), "+r" (a1)
+ : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7)
+ : "memory");
+ ret.error = a0;
+ ret.value = a1;
+
+ return ret;
+}
+
+void sbi_console_putchar(int ch)
+{
+ sbi_ecall(SBI_EXT_0_1_CONSOLE_PUTCHAR, 0, ch, 0, 0, 0, 0, 0);
+}
--
2.39.0
next prev parent reply other threads:[~2023-01-19 12:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 14:39 [PATCH v4 0/4] The patch series introduces the following: Oleksii Kurochko
2023-01-16 14:39 ` [PATCH v4 1/4] xen/riscv: introduce asm/types.h header file Oleksii Kurochko
2023-01-16 14:59 ` Jan Beulich
2023-01-17 9:29 ` Oleksii
2023-01-17 10:04 ` Jan Beulich
2023-01-18 11:23 ` Oleksii
2023-01-18 13:03 ` Jan Beulich
2023-01-19 12:45 ` Oleksii Kurochko
2023-01-16 14:39 ` Oleksii Kurochko [this message]
2023-01-17 23:19 ` [PATCH v4 2/4] xen/riscv: introduce sbi call to putchar to console Bobby Eshleman
2023-01-17 23:32 ` Andrew Cooper
2023-01-18 7:38 ` Jan Beulich
2023-01-18 11:29 ` Oleksii
2023-01-18 1:10 ` Alistair Francis
2023-01-19 12:45 ` Oleksii Kurochko
2023-01-16 14:39 ` [PATCH v4 3/4] xen/riscv: introduce early_printk basic stuff Oleksii Kurochko
2023-01-17 23:22 ` Bobby Eshleman
2023-01-17 23:57 ` Andrew Cooper
2023-01-18 0:33 ` Julien Grall
2023-01-18 11:07 ` Oleksii
2023-01-19 12:45 ` Oleksii Kurochko
2023-01-16 14:39 ` [PATCH v4 4/4] automation: add RISC-V smoke test Oleksii Kurochko
2023-01-18 1:14 ` Alistair Francis
2023-01-19 12:45 ` Oleksii Kurochko
2023-01-16 14:44 ` [PATCH v4 0/4] The patch series introduces the following: Oleksii
2023-01-19 12:45 ` [PATCH v4 0/4] Basic early_printk and smoke test implementation Oleksii Kurochko
2023-01-19 13:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ad9f6c8cbc87284ef4ecd4b85d9c7df33bd2c1.1673877778.git.oleksii.kurochko@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobby.eshleman@gmail.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).