From: Olaf Hering <olaf@aepfle.de>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v1] tools: fix make rpmball
Date: Mon, 12 Jun 2023 13:35:45 +0200 [thread overview]
Message-ID: <20230612133545.1318ce98.olaf@aepfle.de> (raw)
In-Reply-To: <6734a258-3396-4641-b9bf-edf6193a8095@perard>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
Mon, 12 Jun 2023 11:40:55 +0100 Anthony PERARD <anthony.perard@citrix.com>:
> On Tue, May 30, 2023 at 01:18:07PM +0200, Olaf Hering wrote:
> > +pushd %buildroot
> > +popd
> Are these 2 lines left over from testing? They don't appear to do
> anything useful.
I think the intention was to test if mkdir succeeded. But then it
should have been right after mkdir...
I will send v2 without these two lines.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-12 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 11:18 [PATCH v1] tools: fix make rpmball Olaf Hering
2023-06-12 10:40 ` Anthony PERARD
2023-06-12 11:35 ` Olaf Hering [this message]
2023-06-12 11:44 ` Jan Beulich
2023-06-12 11:52 ` Olaf Hering
2023-06-12 11:57 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2021-07-07 13:10 Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612133545.1318ce98.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=anthony.perard@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).