From: Jan Beulich <jbeulich@suse.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v1] tools: fix make rpmball
Date: Mon, 12 Jun 2023 13:57:19 +0200 [thread overview]
Message-ID: <3d7a304b-d41d-0ad6-7057-05978c52bc52@suse.com> (raw)
In-Reply-To: <20230612135226.0190f2e3.olaf@aepfle.de>
On 12.06.2023 13:52, Olaf Hering wrote:
> Mon, 12 Jun 2023 13:44:34 +0200 Jan Beulich <jbeulich@suse.com>:
>
>> On 12.06.2023 13:35, Olaf Hering wrote:
>>> I will send v2 without these two lines.
>> I'd be fine dropping them while committing.
>
> Another cosmetic change in such v2 would be the usage of | instead of @
> in the last sed call, for consistency with the other three earlier sed
> calls. I think it was a result of copy&paste from elsewhere.
I see. If you want that, then please indeed send a v2.
Jan
next prev parent reply other threads:[~2023-06-12 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 11:18 [PATCH v1] tools: fix make rpmball Olaf Hering
2023-06-12 10:40 ` Anthony PERARD
2023-06-12 11:35 ` Olaf Hering
2023-06-12 11:44 ` Jan Beulich
2023-06-12 11:52 ` Olaf Hering
2023-06-12 11:57 ` Jan Beulich [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-07 13:10 Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d7a304b-d41d-0ad6-7057-05978c52bc52@suse.com \
--to=jbeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=olaf@aepfle.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).