* [PATCH OSSTEST] TestSupport: Avoid use of uninitialised $dtbs warning
@ 2015-07-24 12:55 Ian Campbell
2015-07-24 13:37 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Ian Campbell @ 2015-07-24 12:55 UTC (permalink / raw)
To: ian.jackson, xen-devel; +Cc: Ian Campbell
If $xopts{dtbs} wasn't set then neither was $dtbs.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
Osstest/TestSupport.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 7c1bb2c..755a4ab 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -2210,7 +2210,7 @@ sub setup_pxelinux_bootcfg ($$) {
# Systems using BIOS are configured to use pxelinux
sub setup_pxeboot_di_bios ($$$$$;%) {
my ($ho,$kern,$initrd,$dicmd,$hocmd,%xopts) = @_;
- my $dtbs = "fdtdir $xopts{dtbs}" if $xopts{dtbs};
+ my $dtbs = $xopts{dtbs} ? "fdtdir $xopts{dtbs}" : "";
setup_pxelinux_bootcfg($ho, <<END);
serial 0 $c{Baud}
timeout 5
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH OSSTEST] TestSupport: Avoid use of uninitialised $dtbs warning
2015-07-24 12:55 [PATCH OSSTEST] TestSupport: Avoid use of uninitialised $dtbs warning Ian Campbell
@ 2015-07-24 13:37 ` Ian Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2015-07-24 13:37 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel
Ian Campbell writes ("[PATCH OSSTEST] TestSupport: Avoid use of uninitialised $dtbs warning"):
> If $xopts{dtbs} wasn't set then neither was $dtbs.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-24 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-24 12:55 [PATCH OSSTEST] TestSupport: Avoid use of uninitialised $dtbs warning Ian Campbell
2015-07-24 13:37 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).