xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST 2/3] ts-debian-hvm-install: di_installcmdline_core
Date: Fri, 24 Jul 2015 18:11:27 +0100	[thread overview]
Message-ID: <21938.29119.239475.933315@mariner.uk.xensource.com> (raw)
In-Reply-To: <1437405238-22781-2-git-send-email-ian.campbell@citrix.com>

Ian Campbell writes ("[PATCH OSSTEST 2/3] ts-debian-hvm-install: di_installcmdline_core"):
> This is primarily to get DEBIAN_FRONTEND=test, for easier to read
> logging.
...
>  sub grub_cfg () {
> +    my @dicmdline = ();
> +    my $gconsole = "console=ttyS0,115200n8";
> +
> +    push @dicmdline, $gconsole;
> +    push @dicmdline, di_installcmdline_core($gho, '/preseed.cfg',
> +					    PreseedScheme => 'file');
> +    push @dicmdline, "--";
...
>  sub isolinux_cfg () {
> +    my @dicmdline = ();
> +    my $gconsole = "console=ttyS0,115200n8";
> +
> +    push @dicmdline, $gconsole;
> +    push @dicmdline, di_installcmdline_core($gho, '/preseed.cfg',
> +					    PreseedScheme => 'file');
> +    push @dicmdline, "initrd=/install.amd/initrd.gz";
> +    push @dicmdline, "--";
>      # See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762007 for
>      # why console= is repeated.
> +    push @dicmdline, $gconsole;
> +
> +    my $cmdline = join(" ", @dicmdline);

These are uncomfortably similar, don't you think ?

Ian.

  parent reply	other threads:[~2015-07-24 17:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 15:13 [PATCH OSSTEST 0/3] fixes to ts-debian-hvm-install Ian Campbell
2015-07-20 15:13 ` [PATCH OSSTEST 1/3] ts-debian-hvm-install: Remove VGA console runes Ian Campbell
2015-07-24 17:09   ` Ian Jackson
2015-07-20 15:13 ` [PATCH OSSTEST 2/3] ts-debian-hvm-install: di_installcmdline_core Ian Campbell
2015-07-20 15:39   ` Wei Liu
2015-07-20 15:47     ` Ian Campbell
2015-07-24 17:11   ` Ian Jackson [this message]
2015-07-20 15:13 ` [PATCH OSSTEST 3/3] ts-debian-hvm-install: Use xargs -0 to avoid massive filelist in logs Ian Campbell
2015-07-24 17:12   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21938.29119.239475.933315@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).