xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	andrew.cooper3@citrix.com, xen-devel@lists.xen.org,
	julien.grall@arm.com, jbeulich@suse.com,
	zhaoshenglong@huawei.com, roger.pau@citrix.com
Subject: Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries
Date: Tue, 27 Sep 2016 10:24:31 +0100	[thread overview]
Message-ID: <22506.15055.791836.915914@mariner.uk.xensource.com> (raw)
In-Reply-To: <014aeeb6-b3cd-6f63-5f42-f4f73fed9c0b@oracle.com>

Boris Ostrovsky writes ("Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries"):
> This will not produce what I am trying to print tough. I want this sequence:
>     B   C   D   A   C   D   A   B   D   A   B   C   A

I went back to your patch and AFAICT it doesn't generate that
sequence.  But:

I think this conversation has turned into a ridiculous bikeshed
argument, for which I apologise.  The code in your patch is acceptable
from a portability and style pov and I don't think we should spend any
more time trying to make it prettier.

Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-09-27  9:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 19:14 [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries Boris Ostrovsky
2016-09-26  6:46 ` Jan Beulich
2016-09-26 12:49   ` Boris Ostrovsky
2016-09-26 13:08     ` Jan Beulich
2016-09-26 13:43       ` Boris Ostrovsky
2016-09-26 13:51         ` Jan Beulich
2016-09-26 10:04 ` Wei Liu
2016-09-26 10:20   ` Ian Jackson
2016-09-26 10:24     ` Wei Liu
2016-09-26 12:58       ` Boris Ostrovsky
2016-09-26 13:02         ` Wei Liu
2016-09-26 14:45         ` Ian Jackson
2016-09-26 15:03           ` Boris Ostrovsky
2016-09-26 16:48             ` Ian Jackson
2016-09-26 18:20               ` Boris Ostrovsky
2016-09-27  9:24                 ` Ian Jackson [this message]
2016-09-26 14:01   ` Boris Ostrovsky
2016-09-26 14:02     ` Wei Liu
2016-09-26 14:46     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22506.15055.791836.915914@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).