From: "Jan Beulich" <JBeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
julien.grall@arm.com, zhaoshenglong@huawei.com,
roger.pau@citrix.com
Subject: Re: [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries
Date: Mon, 26 Sep 2016 07:51:43 -0600 [thread overview]
Message-ID: <57E9440F02000078001127E1@prv-mh.provo.novell.com> (raw)
In-Reply-To: <43fcbf09-d2fc-3700-fe40-462d9002928b@oracle.com>
>>> On 26.09.16 at 15:43, <boris.ostrovsky@oracle.com> wrote:
> On 09/26/2016 09:08 AM, Jan Beulich wrote:
>>>>> On 26.09.16 at 14:49, <boris.ostrovsky@oracle.com> wrote:
>>> On 09/26/2016 02:46 AM, Jan Beulich wrote:
>>>>>>> On 23.09.16 at 21:14, <boris.ostrovsky@oracle.com> wrote:
>>>>> Changes in v6:
>>>>> * Replaced script's printf in most case with "here document" (for multi-line
>>>>> text) or echo for single line. Left printf for formatted output.
>>>>> (Note that in one case paramter expansion is necessary and so
>>>>> delimiter word is intentionally not quoted).
>>>>> * Replaced bash arrays with ${string:index:size} syntax.
>>>> Without having looked at the patch in full yet - is this any more
>>>> portable than the previous approach? I can't see any mention of
>>>> it in SUSv6 / SUSv7 either.
>>> I can't say for sure but I remember seeing this construct long time ago.
>>>
>>> Of course, this being bash, there are at least 3 ways of doing the same
>>> thing so I can also do
>>>
>>> link=`echo "A B C D" | cut -d" " -f $i`
>>>
>>> Will SUSv6 understand this?
>> Yes, it looks like it will. But you could have checked yourself.
>
>
> Yes, I could. But somehow I thought you were referring to a SUSE product
> instead of the UNIX spec.
>
> Anyway, I will hold off re-sending the patch with this fixed until you
> review the one I sent.
Oh, I've looked over it already, and it looks reasonable once the
comments already given by others have got addressed.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-26 13:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 19:14 [PATCH v6] acpi: Prevent GPL-only code from seeping into non-GPL binaries Boris Ostrovsky
2016-09-26 6:46 ` Jan Beulich
2016-09-26 12:49 ` Boris Ostrovsky
2016-09-26 13:08 ` Jan Beulich
2016-09-26 13:43 ` Boris Ostrovsky
2016-09-26 13:51 ` Jan Beulich [this message]
2016-09-26 10:04 ` Wei Liu
2016-09-26 10:20 ` Ian Jackson
2016-09-26 10:24 ` Wei Liu
2016-09-26 12:58 ` Boris Ostrovsky
2016-09-26 13:02 ` Wei Liu
2016-09-26 14:45 ` Ian Jackson
2016-09-26 15:03 ` Boris Ostrovsky
2016-09-26 16:48 ` Ian Jackson
2016-09-26 18:20 ` Boris Ostrovsky
2016-09-27 9:24 ` Ian Jackson
2016-09-26 14:01 ` Boris Ostrovsky
2016-09-26 14:02 ` Wei Liu
2016-09-26 14:46 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E9440F02000078001127E1@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).