* [PATCH] libxl: fix regression introduced in 5c883cf036cf
@ 2019-05-16 9:11 Wei Liu
2019-05-16 9:11 ` [Xen-devel] " Wei Liu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wei Liu @ 2019-05-16 9:11 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu
Two lines were erroneously deleted during rebase which caused domain
destruction to fail.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Sorry my usual test script failed to catch this.
---
tools/libxl/libxl_device.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
index f8340ba815..db6c0203b7 100644
--- a/tools/libxl/libxl_device.c
+++ b/tools/libxl/libxl_device.c
@@ -734,6 +734,11 @@ int libxl__device_destroy(libxl__gc *gc, libxl__device *dev)
uint32_t domid;
int libxl_only = dev->backend_kind == LIBXL__DEVICE_KIND_NONE;
+ if (!libxl_only) {
+ be_path = libxl__device_backend_path(gc, dev);
+ fe_path = libxl__device_frontend_path(gc, dev);
+ }
+
rc = libxl__get_domid(gc, &domid);
if (rc) goto out;
--
2.20.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Xen-devel] [PATCH] libxl: fix regression introduced in 5c883cf036cf
2019-05-16 9:11 [PATCH] libxl: fix regression introduced in 5c883cf036cf Wei Liu
@ 2019-05-16 9:11 ` Wei Liu
2019-05-16 9:42 ` Juergen Gross
2019-05-16 10:00 ` Ian Jackson
2 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2019-05-16 9:11 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu
Two lines were erroneously deleted during rebase which caused domain
destruction to fail.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Sorry my usual test script failed to catch this.
---
tools/libxl/libxl_device.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
index f8340ba815..db6c0203b7 100644
--- a/tools/libxl/libxl_device.c
+++ b/tools/libxl/libxl_device.c
@@ -734,6 +734,11 @@ int libxl__device_destroy(libxl__gc *gc, libxl__device *dev)
uint32_t domid;
int libxl_only = dev->backend_kind == LIBXL__DEVICE_KIND_NONE;
+ if (!libxl_only) {
+ be_path = libxl__device_backend_path(gc, dev);
+ fe_path = libxl__device_frontend_path(gc, dev);
+ }
+
rc = libxl__get_domid(gc, &domid);
if (rc) goto out;
--
2.20.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: fix regression introduced in 5c883cf036cf
2019-05-16 9:11 [PATCH] libxl: fix regression introduced in 5c883cf036cf Wei Liu
2019-05-16 9:11 ` [Xen-devel] " Wei Liu
@ 2019-05-16 9:42 ` Juergen Gross
2019-05-16 9:42 ` [Xen-devel] " Juergen Gross
2019-05-16 10:00 ` Ian Jackson
2 siblings, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2019-05-16 9:42 UTC (permalink / raw)
To: Wei Liu, xen-devel; +Cc: Ian Jackson
On 16/05/2019 11:11, Wei Liu wrote:
> Two lines were erroneously deleted during rebase which caused domain
> destruction to fail.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] libxl: fix regression introduced in 5c883cf036cf
2019-05-16 9:42 ` Juergen Gross
@ 2019-05-16 9:42 ` Juergen Gross
0 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2019-05-16 9:42 UTC (permalink / raw)
To: Wei Liu, xen-devel; +Cc: Ian Jackson
On 16/05/2019 11:11, Wei Liu wrote:
> Two lines were erroneously deleted during rebase which caused domain
> destruction to fail.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: fix regression introduced in 5c883cf036cf
2019-05-16 9:11 [PATCH] libxl: fix regression introduced in 5c883cf036cf Wei Liu
2019-05-16 9:11 ` [Xen-devel] " Wei Liu
2019-05-16 9:42 ` Juergen Gross
@ 2019-05-16 10:00 ` Ian Jackson
2019-05-16 10:00 ` [Xen-devel] " Ian Jackson
2 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2019-05-16 10:00 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel
Wei Liu writes ("[PATCH] libxl: fix regression introduced in 5c883cf036cf"):
> Two lines were erroneously deleted during rebase which caused domain
> destruction to fail.
I have taken this as a sign that I should have properly reviewed what
became 5c883cf036cf.
Having done so I have also spotted that:
The newly introduced ERROR_FAIL returns in libxl should be ERROR_NI
("not implemented").
But I didn't see anything else, other than the rebase error that you
are fixing now. So for this patch:
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] libxl: fix regression introduced in 5c883cf036cf
2019-05-16 10:00 ` Ian Jackson
@ 2019-05-16 10:00 ` Ian Jackson
0 siblings, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2019-05-16 10:00 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel
Wei Liu writes ("[PATCH] libxl: fix regression introduced in 5c883cf036cf"):
> Two lines were erroneously deleted during rebase which caused domain
> destruction to fail.
I have taken this as a sign that I should have properly reviewed what
became 5c883cf036cf.
Having done so I have also spotted that:
The newly introduced ERROR_FAIL returns in libxl should be ERROR_NI
("not implemented").
But I didn't see anything else, other than the rebase error that you
are fixing now. So for this patch:
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-16 10:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 9:11 [PATCH] libxl: fix regression introduced in 5c883cf036cf Wei Liu
2019-05-16 9:11 ` [Xen-devel] " Wei Liu
2019-05-16 9:42 ` Juergen Gross
2019-05-16 9:42 ` [Xen-devel] " Juergen Gross
2019-05-16 10:00 ` Ian Jackson
2019-05-16 10:00 ` [Xen-devel] " Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).