Re: [Xen-devel] [PATCH 2/3] build: allow picking the env values for compiler variables

From: Ian Jackson <ian.jackson@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, WeiLiu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	"Tim \(Xen.org\)" <tim@xen.org>,
	George Dunlap <George.Dunlap@citrix.com>,
	JulienGrall <julien.grall@arm.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 2/3] build: allow picking the env values for compiler variables
Date: Tue, 27 Aug 2019 11:59:33 +0100	[thread overview]
Message-ID: <23909.3349.210995.572901@mariner.uk.xensource.com> (raw)
In-Reply-To: <8722ee9d-aa68-2871-06d9-e4eedd7797dc@suse.com>

Jan Beulich writes ("Re: [PATCH 2/3] build: allow picking the env values for compiler variables"):
> On 20.08.2019 09:58, Roger Pau Monné  wrote:
> > I don't have things 'left' in the environment, neither have most build
> > systems AFAIK. I do have things set that I want the build to
> > acknowledge, instead of fight against it.
> 
> My view is this: XEN_* things coming from the environment are fine.
> Generic (i.e. project agnostic) variables (like CC) otoh would
> better be ignored, as it's not clear for what purpose they've been
> set. (Istr a case where some FORTIFY option was set by RPM build
> environments, breaking our build.) They may well have been meant
> for some other project.

CC is set *specifically to cause build systems's like Xen's to use
that compiler*.  That is its purpose.  It should be honoured, not
ignored.

Likewise FORTIFY, even though it broke something.  FORTIFY_SOURCE was
set specifically to cause the changes it did.  The people who set it
didn't see all the implications, but that change *was* their design
intent and the bugs were real bugs in what they were trying to do.

> Question is whether to take the above just for the hypervisor part
> of the build, or also the tool stack etc ones.

*Definitely* for the toolstack build, we should honour CC et al.

The hypervisor is a more subtle question because people who set these
variables often forget to think about kernel code, embedded code,
etc.  That's what happened with FORTIFY_SOURCE.  However, I would
argue that it is better, in such a situation, to honour the variable
and break the build, than it is to simply ignore it.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel