From: Jan Beulich <JBeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, TimDeegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH 2/3] build: allow picking the env values for compiler variables
Date: Mon, 29 Jul 2019 15:35:36 +0000 [thread overview]
Message-ID: <f46656a6-22f7-bece-30c2-9be66ab36ef4@suse.com> (raw)
In-Reply-To: <20190726133331.91482-3-roger.pau@citrix.com>
On 26.07.2019 15:33, Roger Pau Monne wrote:
> Don't force the usage of the hardcoded compiler values if those are
> already set on the environment. This allows the Xen build system to
> correctly pick CC/CXX values present on the environment, and fixes the
> usage of those by the Gitlab CI test system.
>
> Note that without this fix the Xen build system will completely ignore
> any CC or CXX values set on the environment, and the only way to pass
> a different CC or CXX is to overwrite it on the make command line.
Now the question is: Do we possibly want it to be that way? I've always
been of the opinion that inheriting something that happens to be (left?)
set in the environment is not a good idea. Hence I've been welcoming all
changes that removed dependencies on settings possibly coming from the
environment. (Exceptions of course are XEN_* environment variables we
specifically evaluate.)
As a result I'm inclined to nak this patch, but I'm open to arguments.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-29 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 13:33 [Xen-devel] [PATCH 0/3] build: honor toolchain related environment vars Roger Pau Monne
2019-07-26 13:33 ` [Xen-devel] [PATCH 1/3] kconfig: include default toolchain values Roger Pau Monne
2019-07-29 15:31 ` Jan Beulich
2019-08-20 7:47 ` Roger Pau Monné
2019-07-26 13:33 ` [Xen-devel] [PATCH 2/3] build: allow picking the env values for compiler variables Roger Pau Monne
2019-07-29 15:35 ` Jan Beulich [this message]
2019-08-20 7:58 ` Roger Pau Monné
2019-08-27 9:17 ` Jan Beulich
2019-08-27 10:59 ` Ian Jackson
2019-08-29 10:30 ` Roger Pau Monné
2019-07-26 13:33 ` [Xen-devel] [PATCH 3/3] build: allow picking the env values for toolchain utilities Roger Pau Monne
2019-07-29 15:39 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f46656a6-22f7-bece-30c2-9be66ab36ef4@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).