Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt
@ 2020-02-14 15:59 Jim Fehlig
  2020-02-14 17:47 ` Ian Jackson
  0 siblings, 1 reply; 3+ messages in thread
From: Jim Fehlig @ 2020-02-14 15:59 UTC (permalink / raw)
  To: xen-devel; +Cc: Jim Fehlig, ian.jackson

libvirt.git commit 2621d48f00 removed the last traces of gnulib, which
also removed the '--no-git' option from autogen.sh. Unknown options are
now passed to the configure script, which quickly fails with

  configure: error: unrecognized option: `--no-git'

Remove the gnulib handling from ts-libvirt-build, including the '--no-git'
option to autogen.sh. While at it remove configure options no longer
supported by the libvirt configure script.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---

The only change from V1 is adding Ian to cc.

I have poor perl skills, but hopefully this fixes the latest build
failures of the libvirt test project, e.g.

http://logs.test-lab.xenproject.org/osstest/logs/146921/build-amd64-libvirt/6.ts-libvirt-build.log

 ts-libvirt-build | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/ts-libvirt-build b/ts-libvirt-build
index e799f003..ac5afcf2 100755
--- a/ts-libvirt-build
+++ b/ts-libvirt-build
@@ -26,8 +26,7 @@ tsreadconfig();
 selectbuildhost(\@ARGV);
 builddirsprops();
 
-our %submodmap = qw(gnulib gnulib
-                    keycodemapdb keycodemapdb);
+our %submodmap = qw(keycodemapdb keycodemapdb);
 our $submodules;
 
 sub libvirtd_init ();
@@ -50,12 +49,6 @@ sub config() {
     }
     die "no xen prefix" unless $xenprefix;
 
-    # Uses --no-git because otherwise autogen.sh will undo
-    # submodulefixup's attempts to honour
-    # revision_libvirt_gnulib. This in turn requires that we specify
-    # --gnulib-srcdir, but ./autogen.sh doesn't propagate
-    # --gnulib-srcdir to ./bootstap so we use GNULIB_SRCDIR directly.
-    my $gnulib = submodule_find($submodules, "gnulib");
     target_cmd_build($ho, 3600, $builddir, <<END);
         cd libvirt
 	mkdir build
@@ -63,10 +56,9 @@ sub config() {
         CFLAGS="-g -I$xenprefix/include/" \\
         LDFLAGS="-g -L$xenprefix/lib/ -Wl,-rpath-link=$xenprefix/lib/" \\
         PKG_CONFIG_PATH="$xenprefix/lib/pkgconfig/" \\
-        GNULIB_SRCDIR=$builddir/libvirt/$gnulib->{Path} \\
-            ../autogen.sh --no-git \\
-                         --with-libxl --without-xen --without-xenapi --without-selinux \\
-                         --without-lxc --without-vbox --without-uml \\
+            ../autogen.sh \\
+                         --with-libxl --without-selinux \\
+                         --without-lxc --without-vbox \\
                          --without-qemu --without-openvz --without-vmware \\
                          --sysconfdir=/etc --localstatedir=/var #/
 END
-- 
2.25.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt
  2020-02-14 15:59 [Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt Jim Fehlig
@ 2020-02-14 17:47 ` Ian Jackson
  2020-02-17 23:41   ` Jim Fehlig
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2020-02-14 17:47 UTC (permalink / raw)
  To: Jim Fehlig; +Cc: xen-devel

Jim Fehlig writes ("[OSSTEST PATCH V2] build: fix configuration of libvirt"):
> libvirt.git commit 2621d48f00 removed the last traces of gnulib, which
> also removed the '--no-git' option from autogen.sh. Unknown options are
> now passed to the configure script, which quickly fails with
> 
>   configure: error: unrecognized option: `--no-git'
> 
> Remove the gnulib handling from ts-libvirt-build, including the '--no-git'
> option to autogen.sh. While at it remove configure options no longer
> supported by the libvirt configure script.

Harmf.  Thanks for looking into this and trying to fix this mess.

I think there is a problem with your patch, which is that 2621d48f00
is recent enough that we might want still to be able to build with
earlier versions.

Is there an easy way to tell (by looking at the tree after checkout,
maybe) whether to do the old or the new thing ?

Your perl code looks good to me for what it is trying to do.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt
  2020-02-14 17:47 ` Ian Jackson
@ 2020-02-17 23:41   ` Jim Fehlig
  0 siblings, 0 replies; 3+ messages in thread
From: Jim Fehlig @ 2020-02-17 23:41 UTC (permalink / raw)
  To: Ian Jackson; +Cc: xen-devel

On 2/14/20 10:47 AM, Ian Jackson wrote:
> Jim Fehlig writes ("[OSSTEST PATCH V2] build: fix configuration of libvirt"):
>> libvirt.git commit 2621d48f00 removed the last traces of gnulib, which
>> also removed the '--no-git' option from autogen.sh. Unknown options are
>> now passed to the configure script, which quickly fails with
>>
>>    configure: error: unrecognized option: `--no-git'
>>
>> Remove the gnulib handling from ts-libvirt-build, including the '--no-git'
>> option to autogen.sh. While at it remove configure options no longer
>> supported by the libvirt configure script.
> 
> Harmf.  Thanks for looking into this and trying to fix this mess.
> 
> I think there is a problem with your patch, which is that 2621d48f00
> is recent enough that we might want still to be able to build with
> earlier versions.

Ah, good point.

> Is there an easy way to tell (by looking at the tree after checkout,
> maybe) whether to do the old or the new thing ?

There would be no gnulib directory in a tree checked out after commit 
2621d48f00. Another option is to check for the 'bootstrap' script in the root of 
the tree, which was removed by 2621d48f00.

> Your perl code looks good to me for what it is trying to do.

I'm afraid my perl is too weak to quickly hack something up to support both pre 
and post gnulib builds :-(. I'll add this task to my list if you don't have time 
for it.

Regards,
Jim

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 15:59 [Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt Jim Fehlig
2020-02-14 17:47 ` Ian Jackson
2020-02-17 23:41   ` Jim Fehlig

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git