From: Ian Jackson <iwj@xenproject.org>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"
Date: Wed, 17 Mar 2021 13:37:51 +0000 [thread overview]
Message-ID: <24658.1583.601613.903527@mariner.uk.xensource.com> (raw)
In-Reply-To: <20210316161844.1658-2-andrew.cooper3@citrix.com>
I have read this thread and with my release manager hat on I feel
confused and/or ignorant.
Patch 3/ has a good explanation of what the problem is it is
addressing and why this is important for 4.15. But then there is
Jan's most recent reply starting "I find all of this confusing". Jan,
can you please tell me in words of one syllable what the implication
of that message is ? In particular is any of what you say a reason
for me to withhold my release-ack ?
AFAICT there is no explanation for why patches 1/ and 2/ deserve to go
into 4.15. We are late in the freeze now, so I would ideally be
looking for a clear and compelling argument. I'd also like to
understand what the risks are of taking these. Can someone please
enlighten me ?
Thanks,
Ian.
next prev parent reply other threads:[~2021-03-17 13:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 16:18 [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 Andrew Cooper
2021-03-16 16:18 ` [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Andrew Cooper
2021-03-16 16:58 ` Jan Beulich
2021-03-19 12:59 ` Andrew Cooper
2021-03-19 13:56 ` Jan Beulich
2021-03-19 14:03 ` Andrew Cooper
2021-03-17 8:40 ` Roger Pau Monné
2021-03-17 13:37 ` Ian Jackson [this message]
2021-03-17 13:45 ` Andrew Cooper
2021-03-17 14:46 ` Ian Jackson
2021-03-17 15:06 ` Roger Pau Monné
2021-03-17 15:15 ` Ian Jackson
2021-03-26 14:25 ` [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages] Ian Jackson
2021-03-26 14:30 ` Ian Jackson
2021-03-29 8:58 ` Roger Pau Monné
2021-03-18 9:37 ` [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Jan Beulich
2021-03-18 9:35 ` Jan Beulich
2021-03-19 13:11 ` Andrew Cooper
2021-03-16 16:18 ` [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14 Andrew Cooper
2021-03-17 8:52 ` Roger Pau Monné
2021-03-19 13:19 ` Andrew Cooper
2021-03-16 16:18 ` [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 Andrew Cooper
2021-03-16 16:56 ` Roger Pau Monné
2021-03-16 17:45 ` Boris Ostrovsky
2021-03-16 21:20 ` Andrew Cooper
2021-03-17 8:32 ` Roger Pau Monné
2021-03-19 13:23 ` Andrew Cooper
2021-03-17 9:26 ` Jan Beulich
2021-03-26 15:08 ` [PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Jan Beulich
2021-03-26 15:13 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24658.1583.601613.903527@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).