From: Ian Jackson <iwj@xenproject.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"
Date: Fri, 26 Mar 2021 15:13:55 +0000 [thread overview]
Message-ID: <24669.64051.783683.771246@mariner.uk.xensource.com> (raw)
In-Reply-To: <b5858e08-627e-742a-055e-84d6768d93f5@suse.com>
Jan Beulich writes ("[PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""):
> From: Andrew Cooper <andrew.cooper3@citrix.com>
>
> In hindsight, this was a poor move. Some of these MSRs require probing for,
> cause unhelpful spew into xl dmesg, or cause spew from unit tests explicitly
> checking behaviour.
>
> This restores behaviour close to that of Xen 4.14, meaning in particular
> that for all of the MSRs getting re-added explicitly a #GP fault will get
> raised irrespective of the new "msr_relaxed" setting.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> Release-Acked-by: Ian Jackson <iwj@xenproject.org>
> ---
> v1.1: Fold in suggested description adjustments.
> ---
> For 4.15. Restoring behaviour closer to 4.14, and prereq for a bugfix needing
> backporting.
Thank you, and thanks for the helpful irc discussion.
Acked-by: Ian Jackson <iwj@xenproject.org>
I will commit this shortly.
For the record, we concluded on irc that we weren't sure that 2/ and
3/ of this series were right, so we are not going to include them in
4.15, pending further consideration/investigation.
Ian.
prev parent reply other threads:[~2021-03-26 15:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 16:18 [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 Andrew Cooper
2021-03-16 16:18 ` [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Andrew Cooper
2021-03-16 16:58 ` Jan Beulich
2021-03-19 12:59 ` Andrew Cooper
2021-03-19 13:56 ` Jan Beulich
2021-03-19 14:03 ` Andrew Cooper
2021-03-17 8:40 ` Roger Pau Monné
2021-03-17 13:37 ` Ian Jackson
2021-03-17 13:45 ` Andrew Cooper
2021-03-17 14:46 ` Ian Jackson
2021-03-17 15:06 ` Roger Pau Monné
2021-03-17 15:15 ` Ian Jackson
2021-03-26 14:25 ` [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages] Ian Jackson
2021-03-26 14:30 ` Ian Jackson
2021-03-29 8:58 ` Roger Pau Monné
2021-03-18 9:37 ` [PATCH 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Jan Beulich
2021-03-18 9:35 ` Jan Beulich
2021-03-19 13:11 ` Andrew Cooper
2021-03-16 16:18 ` [PATCH 2/3] x86/msr: Forward port XSA-351 changes from 4.14 Andrew Cooper
2021-03-17 8:52 ` Roger Pau Monné
2021-03-19 13:19 ` Andrew Cooper
2021-03-16 16:18 ` [PATCH 3/3] x86/msr: Fix Solaris and turbostat following XSA-351 Andrew Cooper
2021-03-16 16:56 ` Roger Pau Monné
2021-03-16 17:45 ` Boris Ostrovsky
2021-03-16 21:20 ` Andrew Cooper
2021-03-17 8:32 ` Roger Pau Monné
2021-03-19 13:23 ` Andrew Cooper
2021-03-17 9:26 ` Jan Beulich
2021-03-26 15:08 ` [PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()" Jan Beulich
2021-03-26 15:13 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24669.64051.783683.771246@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).