From: Jan Beulich <jbeulich@suse.com>
To: Dario Faggioli <dfaggioli@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
Charles Arnold <carnold@suse.com>, Glen <glenbarney@gmail.com>,
George Dunlap <george.dunlap@citrix.com>,
Tomas Mozes <hydrapolic@gmail.com>, Sarah Newman <srn@prgmr.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH 1/2] xen: credit2: avoid vCPUs to ever reach lower credits than idle
Date: Thu, 12 Mar 2020 16:26:16 +0100 [thread overview]
Message-ID: <2e53ee4c-e2d9-f892-c8c3-62bff0c526ab@suse.com> (raw)
In-Reply-To: <158402065414.753.15785539969715690913.stgit@Palanthas>
On 12.03.2020 14:44, Dario Faggioli wrote:
> --- a/xen/common/sched/credit2.c
> +++ b/xen/common/sched/credit2.c
> @@ -234,7 +234,7 @@
> * units does not consume credits, and it must be lower than whatever
> * amount of credit 'regular' unit would end up with.
> */
> -#define CSCHED2_IDLE_CREDIT (-(1U<<30))
> +#define CSCHED2_IDLE_CREDIT INT_MIN
The title saying "lower than", is "equal" actually fine? Looking
at e.g. runq_insert() I'm getting the impression it's not.
Looking at t2c_update() I'm also getting the impression that
there's UB when the subtraction underflows. After all, if
-1 << 30 wasn't small enough a value, I don't see why -1 << 31
would be.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-12 15:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 13:44 [Xen-devel] [PATCH 0/2] xen: credit2: fix vcpu starvation due to too few credits Dario Faggioli
2020-03-12 13:44 ` [Xen-devel] [PATCH 1/2] xen: credit2: avoid vCPUs to ever reach lower credits than idle Dario Faggioli
2020-03-12 13:55 ` Andrew Cooper
2020-03-12 14:40 ` George Dunlap
2020-03-12 15:10 ` Dario Faggioli
2020-03-12 14:58 ` Dario Faggioli
2020-03-12 14:45 ` George Dunlap
2020-03-12 17:03 ` Dario Faggioli
2020-03-12 15:26 ` Jan Beulich [this message]
2020-03-12 16:00 ` Jürgen Groß
2020-03-12 16:59 ` Dario Faggioli
2020-03-12 16:11 ` Dario Faggioli
2020-03-12 16:36 ` Jan Beulich
2020-03-12 13:44 ` [Xen-devel] [PATCH 2/2] xen: credit2: fix credit reset happening too few times Dario Faggioli
2020-03-12 15:08 ` [Xen-devel] [PATCH 0/2] xen: credit2: fix vcpu starvation due to too few credits Roger Pau Monné
2020-03-12 17:02 ` Dario Faggioli
2020-03-12 17:59 ` Roger Pau Monné
2020-03-13 6:19 ` Dario Faggioli
2020-03-12 15:51 ` Jürgen Groß
2020-03-12 16:27 ` Andrew Cooper
2020-03-13 7:26 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e53ee4c-e2d9-f892-c8c3-62bff0c526ab@suse.com \
--to=jbeulich@suse.com \
--cc=carnold@suse.com \
--cc=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=glenbarney@gmail.com \
--cc=hydrapolic@gmail.com \
--cc=jgross@suse.com \
--cc=srn@prgmr.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).