From: Julien Grall <julien@xen.org>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>, nd <nd@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 1/2] xen/arm: Convert runstate address during hypcall
Date: Fri, 12 Jun 2020 21:31:28 +0100 [thread overview]
Message-ID: <2ea01884-a254-47c5-68a7-98ca77afc06b@xen.org> (raw)
In-Reply-To: <71F7AE7B-BB12-4D3B-8337-3FA6040CA632@arm.com>
On 12/06/2020 17:51, Bertrand Marquis wrote:
Hi,
>>> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
>>> index 4e2f582006..3a7f53e13d 100644
>>> --- a/xen/include/asm-arm/domain.h
>>> +++ b/xen/include/asm-arm/domain.h
>>> @@ -11,6 +11,7 @@
>>> #include <asm/vgic.h>
>>> #include <asm/vpl011.h>
>>> #include <public/hvm/params.h>
>>> +#include <public/vcpu.h>
>>
>> Why do you need to add this new include?
>
> Sorry I forgot to answer to this one.
> This is needed to have the definition of vcpu_register_runstate_memory_area.
I might be missing something because nothing you have added this header
seem to require vcpu_register_runstate_memory_area. So should the
include be done in a different header?
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-06-12 20:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:58 [PATCH 0/2] xen/arm: Convert runstate address during hypcall Bertrand Marquis
2020-06-11 11:58 ` [PATCH 1/2] " Bertrand Marquis
2020-06-11 18:16 ` Stefano Stabellini
2020-06-11 18:24 ` Julien Grall
2020-06-11 18:50 ` Stefano Stabellini
2020-06-11 19:38 ` Julien Grall
2020-06-12 1:09 ` Stefano Stabellini
2020-06-12 8:13 ` Bertrand Marquis
2020-06-13 0:24 ` Stefano Stabellini
2020-06-15 14:09 ` Bertrand Marquis
2020-06-15 20:30 ` Stefano Stabellini
2020-06-15 20:44 ` Julien Grall
2020-06-12 9:53 ` Julien Grall
2020-06-13 0:24 ` Stefano Stabellini
2020-06-12 8:07 ` Bertrand Marquis
2020-06-12 10:53 ` Julien Grall
2020-06-12 14:13 ` Bertrand Marquis
2020-06-12 19:56 ` Julien Grall
2020-06-12 16:51 ` Bertrand Marquis
2020-06-12 20:31 ` Julien Grall [this message]
2020-06-15 14:01 ` Bertrand Marquis
2020-06-11 11:58 ` [PATCH 2/2] xen/arm: Support runstate crossing pages Bertrand Marquis
2020-06-12 1:10 ` Stefano Stabellini
2020-06-12 11:37 ` Julien Grall
2020-06-12 12:14 ` Julien Grall
2020-06-12 16:13 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ea01884-a254-47c5-68a7-98ca77afc06b@xen.org \
--to=julien@xen.org \
--cc=Bertrand.Marquis@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=nd@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).