From: Julien Grall <julien@xen.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Jan Beulich" <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>, nd <nd@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Julien Grall" <julien.grall.oss@gmail.com>
Subject: Re: [PATCH 1/2] xen/arm: Convert runstate address during hypcall
Date: Fri, 12 Jun 2020 10:53:29 +0100 [thread overview]
Message-ID: <a8379e95-3f9c-1ee3-61fd-741bb9c41d4b@xen.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2006111250180.2815@sstabellini-ThinkPad-T480s>
On 12/06/2020 02:09, Stefano Stabellini wrote:
> On Thu, 11 Jun 2020, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 11/06/2020 19:50, Stefano Stabellini wrote:
>>> On Thu, 11 Jun 2020, Julien Grall wrote:
>>>>>> + return -EINVAL;
>>>>>> }
>>>>>>
>>>>>> - __copy_to_guest(runstate_guest(v), &runstate, 1);
>>>>>> + v->arch.runstate_guest.page = page;
>>>>>> + v->arch.runstate_guest.offset = offset;
>>>>>> +
>>>>>> + spin_unlock(&v->arch.runstate_guest.lock);
>>>>>> +
>>>>>> + return 0;
>>>>>> +}
>>>>>> +
>>>>>> +
>>>>>> +/* Update per-VCPU guest runstate shared memory area (if registered).
>>>>>> */
>>>>>> +static void update_runstate_area(struct vcpu *v)
>>>>>> +{
>>>>>> + struct vcpu_runstate_info *guest_runstate;
>>>>>> + void *p;
>>>>>> +
>>>>>> + spin_lock(&v->arch.runstate_guest.lock);
>>>>>>
>>>>>> - if ( guest_handle )
>>>>>> + if ( v->arch.runstate_guest.page )
>>>>>> {
>>>>>> - runstate.state_entry_time &= ~XEN_RUNSTATE_UPDATE;
>>>>>> + p = __map_domain_page(v->arch.runstate_guest.page);
>>>>>> + guest_runstate = p + v->arch.runstate_guest.offset;
>>>>>> +
>>>>>> + if ( VM_ASSIST(v->domain, runstate_update_flag) )
>>>>>> + {
>>>>>> + v->runstate.state_entry_time |= XEN_RUNSTATE_UPDATE;
>>>>>> + guest_runstate->state_entry_time |= XEN_RUNSTATE_UPDATE;
>>>>>
>>>>> I think that this write to guest_runstate should use write_atomic or
>>>>> another atomic write operation.
>>>>
>>>> I thought about suggesting the same, but guest_copy_* helpers may not
>>>> do a single memory write to state_entry_time.
>>>> What are you trying to prevent with the write_atomic()?
>>>
>>> I am thinking that without using an atomic write, it would be (at least
>>> theoretically) possible for a guest to see a partial write to
>>> state_entry_time, which is not good.
>>
>> It is already the case with existing implementation as Xen may write byte by
>> byte. So are you suggesting the existing code is also buggy?
It looks like I may have misread the code as we only copy one byte. But
I still think this is fragile.
For this context, I agree that a write_atomic() should do the job.
However, I still want to answer to your comments below.
>
> Writing byte by byte is a different case. That is OK. In that case, the
> guest could see the state after 3 bytes written and it would be fine and
> consistent.
Why? What does actually prevent a guest to see an in-between value?
To give a concrete example, if the original value is 0xabc and you want
to write 0xdef. Why would the guest never see 0xabf or 0xaec?
> If this hadn't been the case, then yes, the existing code
> would also be buggy.
>
> So if we did the write with a memcpy, it would be fine, no need for
> atomics:
>
> memcpy(&guest_runstate->state_entry_time,
> &v->runstate.state_entry_time,
> XXX);
>
>
> The |= case is different: GCC could implement it in any way it likes,
> including going through a zero-write to any of the bytes in the word, or
> doing an addition then a subtraction. GCC doesn't make any guarantees.
> If we want guarantees we need to use atomics.
Yes GCC can generate assembly for |= in any way it likes. But so does
for memcpy(). So I still don't understand why one would be fine for you
and not the other...
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-06-12 9:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:58 [PATCH 0/2] xen/arm: Convert runstate address during hypcall Bertrand Marquis
2020-06-11 11:58 ` [PATCH 1/2] " Bertrand Marquis
2020-06-11 18:16 ` Stefano Stabellini
2020-06-11 18:24 ` Julien Grall
2020-06-11 18:50 ` Stefano Stabellini
2020-06-11 19:38 ` Julien Grall
2020-06-12 1:09 ` Stefano Stabellini
2020-06-12 8:13 ` Bertrand Marquis
2020-06-13 0:24 ` Stefano Stabellini
2020-06-15 14:09 ` Bertrand Marquis
2020-06-15 20:30 ` Stefano Stabellini
2020-06-15 20:44 ` Julien Grall
2020-06-12 9:53 ` Julien Grall [this message]
2020-06-13 0:24 ` Stefano Stabellini
2020-06-12 8:07 ` Bertrand Marquis
2020-06-12 10:53 ` Julien Grall
2020-06-12 14:13 ` Bertrand Marquis
2020-06-12 19:56 ` Julien Grall
2020-06-12 16:51 ` Bertrand Marquis
2020-06-12 20:31 ` Julien Grall
2020-06-15 14:01 ` Bertrand Marquis
2020-06-11 11:58 ` [PATCH 2/2] xen/arm: Support runstate crossing pages Bertrand Marquis
2020-06-12 1:10 ` Stefano Stabellini
2020-06-12 11:37 ` Julien Grall
2020-06-12 12:14 ` Julien Grall
2020-06-12 16:13 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8379e95-3f9c-1ee3-61fd-741bb9c41d4b@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall.oss@gmail.com \
--cc=nd@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).