* [PATCH] docs: update xenstore-migration.md
@ 2020-05-20 10:16 Juergen Gross
2020-05-20 10:50 ` Paul Durrant
2020-05-20 11:19 ` Julien Grall
0 siblings, 2 replies; 3+ messages in thread
From: Juergen Gross @ 2020-05-20 10:16 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, Stefano Stabellini, Julien Grall, Wei Liu,
Andrew Cooper, Ian Jackson, George Dunlap, Jan Beulich
Update connection record details: make flags common for sockets and
domains, and add pending incoming data.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
docs/designs/xenstore-migration.md | 63 ++++++++++++++++--------------
1 file changed, 34 insertions(+), 29 deletions(-)
diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
index 34a2afd17e..e361d6b5e7 100644
--- a/docs/designs/xenstore-migration.md
+++ b/docs/designs/xenstore-migration.md
@@ -147,31 +147,45 @@ the domain being migrated.
```
0 1 2 3 4 5 6 7 octet
+-------+-------+-------+-------+-------+-------+-------+-------+
-| conn-id | conn-type | conn-spec
+| conn-id | conn-type | flags |
++-------------------------------+---------------+---------------+
+| conn-spec
...
+-------------------------------+-------------------------------+
-| data-len | data
-+-------------------------------+
+| in-data-len | out-data-len |
++-------------------------------+-------------------------------+
+| data
...
```
-| Field | Description |
-|-------------|-------------------------------------------------|
-| `conn-id` | A non-zero number used to identify this |
-| | connection in subsequent connection-specific |
-| | records |
-| | |
-| `conn-type` | 0x0000: shared ring |
-| | 0x0001: socket |
-| | 0x0002 - 0xFFFF: reserved for future use |
-| | |
-| `conn-spec` | See below |
-| | |
-| `data-len` | The length (in octets) of any pending data not |
-| | yet written to the connection |
-| | |
-| `data` | Pending data (may be empty) |
+| Field | Description |
+|----------------|----------------------------------------------|
+| `conn-id` | A non-zero number used to identify this |
+| | connection in subsequent connection-specific |
+| | records |
+| | |
+| `flags` | A bit-wise OR of: |
+| | 0001: read-only |
+| | |
+| `conn-type` | 0x0000: shared ring |
+| | 0x0001: socket |
+| | 0x0002 - 0xFFFF: reserved for future use |
+| | |
+| `conn-spec` | See below |
+| | |
+| `in-data-len` | The length (in octets) of any data read |
+| | from the connection not yet processed |
+| | |
+| `out-data-len` | The length (in octets) of any pending data |
+| | not yet written to the connection |
+| | |
+| `data` | Pending data, first read data, then written |
+| | data (any of both may be empty) |
+
+In case of live update the connection record for the connection via which
+the live update command was issued will contain the response for the live
+update command in the pending write data.
The format of `conn-spec` is dependent upon `conn-type`.
@@ -182,8 +196,6 @@ For `shared ring` connections it is as follows:
```
0 1 2 3 4 5 6 7 octet
- +-------+-------+
- | flags |
+---------------+---------------+---------------+---------------+
| domid | tdomid | evtchn |
+-------------------------------+-------------------------------+
@@ -198,8 +210,6 @@ For `shared ring` connections it is as follows:
| | it has been subject to an SET_TARGET |
| | operation [2] or DOMID_INVALID [3] otherwise |
| | |
-| `flags` | Must be zero |
-| | |
| `evtchn` | The port number of the interdomain channel used |
| | by `domid` to communicate with xenstored |
| | |
@@ -211,8 +221,6 @@ For `socket` connections it is as follows:
```
- +-------+-------+
- | flags |
+---------------+---------------+---------------+---------------+
| socket-fd | pad |
+-------------------------------+-------------------------------+
@@ -221,9 +229,6 @@ For `socket` connections it is as follows:
| Field | Description |
|-------------|-------------------------------------------------|
-| `flags` | A bit-wise OR of: |
-| | 0001: read-only |
-| | |
| `socket-fd` | The file descriptor of the connected socket |
This type of connection is only relevant for live update, where the xenstored
@@ -398,4 +403,4 @@ explanation of node permissions.
[3] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/xen.h;hb=HEAD#l612
-[4] https://wiki.xen.org/wiki/XenBus
\ No newline at end of file
+[4] https://wiki.xen.org/wiki/XenBus
--
2.26.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] docs: update xenstore-migration.md
2020-05-20 10:16 [PATCH] docs: update xenstore-migration.md Juergen Gross
@ 2020-05-20 10:50 ` Paul Durrant
2020-05-20 11:19 ` Julien Grall
1 sibling, 0 replies; 3+ messages in thread
From: Paul Durrant @ 2020-05-20 10:50 UTC (permalink / raw)
To: 'Juergen Gross', xen-devel
Cc: 'Stefano Stabellini', 'Julien Grall',
'Wei Liu', 'Andrew Cooper', 'Ian Jackson',
'George Dunlap', 'Jan Beulich'
> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of Juergen Gross
> Sent: 20 May 2020 11:16
> To: xen-devel@lists.xenproject.org
> Cc: Juergen Gross <jgross@suse.com>; Stefano Stabellini <sstabellini@kernel.org>; Julien Grall
> <julien@xen.org>; Wei Liu <wl@xen.org>; Andrew Cooper <andrew.cooper3@citrix.com>; Ian Jackson
> <ian.jackson@eu.citrix.com>; George Dunlap <george.dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>
> Subject: [PATCH] docs: update xenstore-migration.md
>
> Update connection record details: make flags common for sockets and
> domains, and add pending incoming data.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
LGTM
Reviewed-by: Paul Durrant <paul@xen.org>
> ---
> docs/designs/xenstore-migration.md | 63 ++++++++++++++++--------------
> 1 file changed, 34 insertions(+), 29 deletions(-)
>
> diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
> index 34a2afd17e..e361d6b5e7 100644
> --- a/docs/designs/xenstore-migration.md
> +++ b/docs/designs/xenstore-migration.md
> @@ -147,31 +147,45 @@ the domain being migrated.
> ```
> 0 1 2 3 4 5 6 7 octet
> +-------+-------+-------+-------+-------+-------+-------+-------+
> -| conn-id | conn-type | conn-spec
> +| conn-id | conn-type | flags |
> ++-------------------------------+---------------+---------------+
> +| conn-spec
> ...
> +-------------------------------+-------------------------------+
> -| data-len | data
> -+-------------------------------+
> +| in-data-len | out-data-len |
> ++-------------------------------+-------------------------------+
> +| data
> ...
> ```
>
>
> -| Field | Description |
> -|-------------|-------------------------------------------------|
> -| `conn-id` | A non-zero number used to identify this |
> -| | connection in subsequent connection-specific |
> -| | records |
> -| | |
> -| `conn-type` | 0x0000: shared ring |
> -| | 0x0001: socket |
> -| | 0x0002 - 0xFFFF: reserved for future use |
> -| | |
> -| `conn-spec` | See below |
> -| | |
> -| `data-len` | The length (in octets) of any pending data not |
> -| | yet written to the connection |
> -| | |
> -| `data` | Pending data (may be empty) |
> +| Field | Description |
> +|----------------|----------------------------------------------|
> +| `conn-id` | A non-zero number used to identify this |
> +| | connection in subsequent connection-specific |
> +| | records |
> +| | |
> +| `flags` | A bit-wise OR of: |
> +| | 0001: read-only |
> +| | |
> +| `conn-type` | 0x0000: shared ring |
> +| | 0x0001: socket |
> +| | 0x0002 - 0xFFFF: reserved for future use |
> +| | |
> +| `conn-spec` | See below |
> +| | |
> +| `in-data-len` | The length (in octets) of any data read |
> +| | from the connection not yet processed |
> +| | |
> +| `out-data-len` | The length (in octets) of any pending data |
> +| | not yet written to the connection |
> +| | |
> +| `data` | Pending data, first read data, then written |
> +| | data (any of both may be empty) |
> +
> +In case of live update the connection record for the connection via which
> +the live update command was issued will contain the response for the live
> +update command in the pending write data.
>
> The format of `conn-spec` is dependent upon `conn-type`.
>
> @@ -182,8 +196,6 @@ For `shared ring` connections it is as follows:
>
> ```
> 0 1 2 3 4 5 6 7 octet
> - +-------+-------+
> - | flags |
> +---------------+---------------+---------------+---------------+
> | domid | tdomid | evtchn |
> +-------------------------------+-------------------------------+
> @@ -198,8 +210,6 @@ For `shared ring` connections it is as follows:
> | | it has been subject to an SET_TARGET |
> | | operation [2] or DOMID_INVALID [3] otherwise |
> | | |
> -| `flags` | Must be zero |
> -| | |
> | `evtchn` | The port number of the interdomain channel used |
> | | by `domid` to communicate with xenstored |
> | | |
> @@ -211,8 +221,6 @@ For `socket` connections it is as follows:
>
>
> ```
> - +-------+-------+
> - | flags |
> +---------------+---------------+---------------+---------------+
> | socket-fd | pad |
> +-------------------------------+-------------------------------+
> @@ -221,9 +229,6 @@ For `socket` connections it is as follows:
>
> | Field | Description |
> |-------------|-------------------------------------------------|
> -| `flags` | A bit-wise OR of: |
> -| | 0001: read-only |
> -| | |
> | `socket-fd` | The file descriptor of the connected socket |
>
> This type of connection is only relevant for live update, where the xenstored
> @@ -398,4 +403,4 @@ explanation of node permissions.
>
> [3] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/xen.h;hb=HEAD#l612
>
> -[4] https://wiki.xen.org/wiki/XenBus
> \ No newline at end of file
> +[4] https://wiki.xen.org/wiki/XenBus
> --
> 2.26.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: update xenstore-migration.md
2020-05-20 10:16 [PATCH] docs: update xenstore-migration.md Juergen Gross
2020-05-20 10:50 ` Paul Durrant
@ 2020-05-20 11:19 ` Julien Grall
1 sibling, 0 replies; 3+ messages in thread
From: Julien Grall @ 2020-05-20 11:19 UTC (permalink / raw)
To: Juergen Gross, xen-devel
Cc: Stefano Stabellini, Wei Liu, Andrew Cooper, Ian Jackson,
George Dunlap, Jan Beulich
On 20/05/2020 11:16, Juergen Gross wrote:
> Update connection record details: make flags common for sockets and
> domains, and add pending incoming data.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
> ---
> docs/designs/xenstore-migration.md | 63 ++++++++++++++++--------------
> 1 file changed, 34 insertions(+), 29 deletions(-)
>
> diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
> index 34a2afd17e..e361d6b5e7 100644
> --- a/docs/designs/xenstore-migration.md
> +++ b/docs/designs/xenstore-migration.md
> @@ -147,31 +147,45 @@ the domain being migrated.
> ```
> 0 1 2 3 4 5 6 7 octet
> +-------+-------+-------+-------+-------+-------+-------+-------+
> -| conn-id | conn-type | conn-spec
> +| conn-id | conn-type | flags |
> ++-------------------------------+---------------+---------------+
> +| conn-spec
> ...
> +-------------------------------+-------------------------------+
> -| data-len | data
> -+-------------------------------+
> +| in-data-len | out-data-len |
> ++-------------------------------+-------------------------------+
> +| data
> ...
> ```
>
>
> -| Field | Description |
> -|-------------|-------------------------------------------------|
> -| `conn-id` | A non-zero number used to identify this |
> -| | connection in subsequent connection-specific |
> -| | records |
> -| | |
> -| `conn-type` | 0x0000: shared ring |
> -| | 0x0001: socket |
> -| | 0x0002 - 0xFFFF: reserved for future use |
> -| | |
> -| `conn-spec` | See below |
> -| | |
> -| `data-len` | The length (in octets) of any pending data not |
> -| | yet written to the connection |
> -| | |
> -| `data` | Pending data (may be empty) |
> +| Field | Description |
> +|----------------|----------------------------------------------|
> +| `conn-id` | A non-zero number used to identify this |
> +| | connection in subsequent connection-specific |
> +| | records |
> +| | |
> +| `flags` | A bit-wise OR of: |
> +| | 0001: read-only |
> +| | |
> +| `conn-type` | 0x0000: shared ring |
> +| | 0x0001: socket |
> +| | 0x0002 - 0xFFFF: reserved for future use |
> +| | |
> +| `conn-spec` | See below |
> +| | |
> +| `in-data-len` | The length (in octets) of any data read |
> +| | from the connection not yet processed |
> +| | |
> +| `out-data-len` | The length (in octets) of any pending data |
> +| | not yet written to the connection |
> +| | |
> +| `data` | Pending data, first read data, then written |
> +| | data (any of both may be empty) |
> +
> +In case of live update the connection record for the connection via which
> +the live update command was issued will contain the response for the live
> +update command in the pending write data.
>
> The format of `conn-spec` is dependent upon `conn-type`.
>
> @@ -182,8 +196,6 @@ For `shared ring` connections it is as follows:
>
> ```
> 0 1 2 3 4 5 6 7 octet
> - +-------+-------+
> - | flags |
> +---------------+---------------+---------------+---------------+
> | domid | tdomid | evtchn |
> +-------------------------------+-------------------------------+
> @@ -198,8 +210,6 @@ For `shared ring` connections it is as follows:
> | | it has been subject to an SET_TARGET |
> | | operation [2] or DOMID_INVALID [3] otherwise |
> | | |
> -| `flags` | Must be zero |
> -| | |
> | `evtchn` | The port number of the interdomain channel used |
> | | by `domid` to communicate with xenstored |
> | | |
> @@ -211,8 +221,6 @@ For `socket` connections it is as follows:
>
>
> ```
> - +-------+-------+
> - | flags |
> +---------------+---------------+---------------+---------------+
> | socket-fd | pad |
> +-------------------------------+-------------------------------+
> @@ -221,9 +229,6 @@ For `socket` connections it is as follows:
>
> | Field | Description |
> |-------------|-------------------------------------------------|
> -| `flags` | A bit-wise OR of: |
> -| | 0001: read-only |
> -| | |
> | `socket-fd` | The file descriptor of the connected socket |
>
> This type of connection is only relevant for live update, where the xenstored
> @@ -398,4 +403,4 @@ explanation of node permissions.
>
> [3] See https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/xen.h;hb=HEAD#l612
>
> -[4] https://wiki.xen.org/wiki/XenBus
> \ No newline at end of file
> +[4] https://wiki.xen.org/wiki/XenBus
>
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-20 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 10:16 [PATCH] docs: update xenstore-migration.md Juergen Gross
2020-05-20 10:50 ` Paul Durrant
2020-05-20 11:19 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).