* [PATCH] libxl: User defined max_maptrack_frames in a stub domain @ 2020-09-14 14:50 Dmitry Fedorov 2020-09-14 15:27 ` Andrew Cooper 0 siblings, 1 reply; 6+ messages in thread From: Dmitry Fedorov @ 2020-09-14 14:50 UTC (permalink / raw) To: xen-devel Hi, Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to an issue where a device model stub domain doesn't have maptrack entries. Would it be possible to apply a user defined max_maptrack_frames value to dm_config in the same way as for max_grant_frames? Signed-off-by: Dmitry Fedorov <d.fedorov@tabit.pro> --- tools/libxl/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index f2dc5696b9..f044f2566c 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -2292,7 +2292,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss) dm_config->b_info.target_memkb = dm_config->b_info.max_memkb; dm_config->b_info.max_grant_frames = guest_config->b_info.max_grant_frames; - dm_config->b_info.max_maptrack_frames = 0; + dm_config->b_info.max_maptrack_frames = guest_config->b_info.max_maptrack_frames; dm_config->b_info.u.pv.features = ""; -- 2.26.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: User defined max_maptrack_frames in a stub domain 2020-09-14 14:50 [PATCH] libxl: User defined max_maptrack_frames in a stub domain Dmitry Fedorov @ 2020-09-14 15:27 ` Andrew Cooper 2020-09-22 13:30 ` Wei Liu 0 siblings, 1 reply; 6+ messages in thread From: Andrew Cooper @ 2020-09-14 15:27 UTC (permalink / raw) To: Dmitry Fedorov, xen-devel, Ian Jackson, Anthony PERARD, Wei Liu On 14/09/2020 15:50, Dmitry Fedorov wrote: > Hi, > > Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to > an issue where a device model stub domain doesn't have maptrack entries. > > Would it be possible to apply a user defined max_maptrack_frames value > to dm_config in the same way as for max_grant_frames? > > Signed-off-by: Dmitry Fedorov <d.fedorov@tabit.pro> This looks entirely reasonable. CC'ing the maintainers for their opinion. ~Andrew > --- > tools/libxl/libxl_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index f2dc5696b9..f044f2566c 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -2292,7 +2292,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, > libxl__stub_dm_spawn_state *sdss) > dm_config->b_info.target_memkb = dm_config->b_info.max_memkb; > > dm_config->b_info.max_grant_frames = > guest_config->b_info.max_grant_frames; > - dm_config->b_info.max_maptrack_frames = 0; > + dm_config->b_info.max_maptrack_frames = > guest_config->b_info.max_maptrack_frames; > > dm_config->b_info.u.pv.features = ""; > > -- > 2.26.2 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: User defined max_maptrack_frames in a stub domain 2020-09-14 15:27 ` Andrew Cooper @ 2020-09-22 13:30 ` Wei Liu 2021-04-10 15:55 ` Jason Andryuk 0 siblings, 1 reply; 6+ messages in thread From: Wei Liu @ 2020-09-22 13:30 UTC (permalink / raw) To: Andrew Cooper Cc: Dmitry Fedorov, xen-devel, Ian Jackson, Anthony PERARD, Wei Liu On Mon, Sep 14, 2020 at 04:27:45PM +0100, Andrew Cooper wrote: > On 14/09/2020 15:50, Dmitry Fedorov wrote: > > Hi, > > > > Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to > > an issue where a device model stub domain doesn't have maptrack entries. > > > > Would it be possible to apply a user defined max_maptrack_frames value > > to dm_config in the same way as for max_grant_frames? > > > > Signed-off-by: Dmitry Fedorov <d.fedorov@tabit.pro> > > This looks entirely reasonable. > > CC'ing the maintainers for their opinion. > Looks fine to me. Acked-by: Wei Liu <wl@xen.org> > ~Andrew > > > --- > > tools/libxl/libxl_dm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > index f2dc5696b9..f044f2566c 100644 > > --- a/tools/libxl/libxl_dm.c > > +++ b/tools/libxl/libxl_dm.c > > @@ -2292,7 +2292,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, > > libxl__stub_dm_spawn_state *sdss) > > dm_config->b_info.target_memkb = dm_config->b_info.max_memkb; > > > > dm_config->b_info.max_grant_frames = > > guest_config->b_info.max_grant_frames; > > - dm_config->b_info.max_maptrack_frames = 0; > > + dm_config->b_info.max_maptrack_frames = > > guest_config->b_info.max_maptrack_frames; > > > > dm_config->b_info.u.pv.features = ""; > > > > -- > > 2.26.2 > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: User defined max_maptrack_frames in a stub domain 2020-09-22 13:30 ` Wei Liu @ 2021-04-10 15:55 ` Jason Andryuk 2021-04-13 14:23 ` Andrew Cooper 0 siblings, 1 reply; 6+ messages in thread From: Jason Andryuk @ 2021-04-10 15:55 UTC (permalink / raw) To: Wei Liu Cc: Andrew Cooper, Dmitry Fedorov, xen-devel, Ian Jackson, Anthony PERARD On Tue, Sep 22, 2020 at 9:31 AM Wei Liu <wl@xen.org> wrote: > > On Mon, Sep 14, 2020 at 04:27:45PM +0100, Andrew Cooper wrote: > > On 14/09/2020 15:50, Dmitry Fedorov wrote: > > > Hi, > > > > > > Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to > > > an issue where a device model stub domain doesn't have maptrack entries. > > > > > > Would it be possible to apply a user defined max_maptrack_frames value > > > to dm_config in the same way as for max_grant_frames? > > > > > > Signed-off-by: Dmitry Fedorov <d.fedorov@tabit.pro> > > > > This looks entirely reasonable. > > > > CC'ing the maintainers for their opinion. > > > > Looks fine to me. > > Acked-by: Wei Liu <wl@xen.org> Hi, Wei, looks like you Acked but did not apply this patch. And after the libs rename, the file paths no longer match. Do you want to fix this up, or should Dmitry re-submit? Regards, Jason > > ~Andrew > > > > > --- > > > tools/libxl/libxl_dm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > > > index f2dc5696b9..f044f2566c 100644 > > > --- a/tools/libxl/libxl_dm.c > > > +++ b/tools/libxl/libxl_dm.c > > > @@ -2292,7 +2292,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, > > > libxl__stub_dm_spawn_state *sdss) > > > dm_config->b_info.target_memkb = dm_config->b_info.max_memkb; > > > > > > dm_config->b_info.max_grant_frames = > > > guest_config->b_info.max_grant_frames; > > > - dm_config->b_info.max_maptrack_frames = 0; > > > + dm_config->b_info.max_maptrack_frames = > > > guest_config->b_info.max_maptrack_frames; > > > > > > dm_config->b_info.u.pv.features = ""; > > > > > > -- > > > 2.26.2 > > > > > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: User defined max_maptrack_frames in a stub domain 2021-04-10 15:55 ` Jason Andryuk @ 2021-04-13 14:23 ` Andrew Cooper 2021-04-13 16:06 ` Jason Andryuk 0 siblings, 1 reply; 6+ messages in thread From: Andrew Cooper @ 2021-04-13 14:23 UTC (permalink / raw) To: Jason Andryuk, Wei Liu Cc: Dmitry Fedorov, xen-devel, Ian Jackson, Anthony PERARD On 10/04/2021 16:55, Jason Andryuk wrote: > On Tue, Sep 22, 2020 at 9:31 AM Wei Liu <wl@xen.org> wrote: >> On Mon, Sep 14, 2020 at 04:27:45PM +0100, Andrew Cooper wrote: >>> On 14/09/2020 15:50, Dmitry Fedorov wrote: >>>> Hi, >>>> >>>> Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to >>>> an issue where a device model stub domain doesn't have maptrack entries. >>>> >>>> Would it be possible to apply a user defined max_maptrack_frames value >>>> to dm_config in the same way as for max_grant_frames? >>>> >>>> Signed-off-by: Dmitry Fedorov <d.fedorov@tabit.pro> >>> This looks entirely reasonable. >>> >>> CC'ing the maintainers for their opinion. >>> >> Looks fine to me. >> >> Acked-by: Wei Liu <wl@xen.org> > Hi, > > Wei, looks like you Acked but did not apply this patch. And after the > libs rename, the file paths no longer match. Do you want to fix this > up, or should Dmitry re-submit? Apologies for the process failure here. I have committed https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=80714e55042b2242cd82eccfb7405d671ecbebda I take it that it wants flagging for backports? ~Andrew ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: User defined max_maptrack_frames in a stub domain 2021-04-13 14:23 ` Andrew Cooper @ 2021-04-13 16:06 ` Jason Andryuk 0 siblings, 0 replies; 6+ messages in thread From: Jason Andryuk @ 2021-04-13 16:06 UTC (permalink / raw) To: Andrew Cooper Cc: Wei Liu, Dmitry Fedorov, xen-devel, Ian Jackson, Anthony PERARD On Tue, Apr 13, 2021 at 10:23 AM Andrew Cooper <andrew.cooper3@citrix.com> wrote: > > On 10/04/2021 16:55, Jason Andryuk wrote: > > On Tue, Sep 22, 2020 at 9:31 AM Wei Liu <wl@xen.org> wrote: > >> On Mon, Sep 14, 2020 at 04:27:45PM +0100, Andrew Cooper wrote: > >>> On 14/09/2020 15:50, Dmitry Fedorov wrote: > >>>> Hi, > >>>> > >>>> Implementing qrexec+usbip+qemu in Linux-based stub domain leads me to > >>>> an issue where a device model stub domain doesn't have maptrack entries. > >>>> > >>>> Would it be possible to apply a user defined max_maptrack_frames value > >>>> to dm_config in the same way as for max_grant_frames? > >>>> > >>>> Signed-off-by: Dmitry Fedorov <d.fedorov@tabit.pro> > >>> This looks entirely reasonable. > >>> > >>> CC'ing the maintainers for their opinion. > >>> > >> Looks fine to me. > >> > >> Acked-by: Wei Liu <wl@xen.org> > > Hi, > > > > Wei, looks like you Acked but did not apply this patch. And after the > > libs rename, the file paths no longer match. Do you want to fix this > > up, or should Dmitry re-submit? > > Apologies for the process failure here. No worries. > I have committed > https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=80714e55042b2242cd82eccfb7405d671ecbebda Thank you, Andrew. > I take it that it wants flagging for backports? The Qubes qrexec+usbip+qemu feature isn't merged yet, but they have a backport to 4.14 as part of the series. Regards, Jason ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-13 16:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-14 14:50 [PATCH] libxl: User defined max_maptrack_frames in a stub domain Dmitry Fedorov 2020-09-14 15:27 ` Andrew Cooper 2020-09-22 13:30 ` Wei Liu 2021-04-10 15:55 ` Jason Andryuk 2021-04-13 14:23 ` Andrew Cooper 2021-04-13 16:06 ` Jason Andryuk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).