xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Stefano Stabellini <sstabellini@kernel.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Rahul Singh <Rahul.Singh@arm.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Subject: Re: [PATCH] xen/arm : smmuv3: Fix to handle multiple StreamIds per device.
Date: Fri, 19 Feb 2021 14:46:12 +0000	[thread overview]
Message-ID: <32e14e21-86de-9c74-e94a-ff29bda56b3a@xen.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2102171522420.3234@sstabellini-ThinkPad-T480s>


On 17/02/2021 23:23, Stefano Stabellini wrote:
> +IanJ
> On Wed, 17 Feb 2021, Bertrand Marquis wrote:
>> Hi Rahul,
>>> On 17 Feb 2021, at 10:05, Rahul Singh <Rahul.Singh@arm.com> wrote:
>>> SMMUv3 driver does not handle multiple StreamId if the master device
>>> supports more than one StreamID.
>>> This bug was introduced when the driver was ported from Linux to XEN.
>>> dt_device_set_protected(..) should be called from add_device(..) not
>>> from the dt_xlate(..).
>>> Move dt_device_set_protected(..) from dt_xlate(..) to add_device().
>>> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> Thanks a lot, this is fixing issues with multiple stream ids for one device :-)
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>> ---
>>> This patch is a candidate for 4.15 as without this patch it is not possible to
>>> assign multiple StreamIds to the same device when device is protected behind
>>> SMMUv3.
> I agree especially considering that the impact is limited to smmu-v3.c.

SMMUv3 is in tech preview, so the risk is pretty low as we don't support 
it :).

But, a release ack from Ian is not necessary until tonight (19th 
February) for bug fixes. So I have committed the patch.


Julien Grall

      reply	other threads:[~2021-02-19 14:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 10:05 [PATCH] xen/arm : smmuv3: Fix to handle multiple StreamIds per device Rahul Singh
2021-02-17 11:37 ` Bertrand Marquis
2021-02-17 23:23   ` Stefano Stabellini
2021-02-19 14:46     ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32e14e21-86de-9c74-e94a-ff29bda56b3a@xen.org \
    --to=julien@xen.org \
    --cc=Bertrand.Marquis@arm.com \
    --cc=Rahul.Singh@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=iwj@xenproject.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).