* [PATCH] x86/APIC: drop 32-bit days remnants
@ 2022-01-17 10:33 Jan Beulich
2022-01-20 16:11 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-01-17 10:33 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
Mercury and Neptune were Pentium chipsets - no need to work around their
errata, even more so that the workaround looks fragile.
Also ditch a Pentium-related and stale part of a comment.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1042,11 +1042,6 @@ static void __init wait_8254_wraparound(
do {
prev_count = curr_count;
curr_count = get_8254_timer_count();
-
- /* workaround for broken Mercury/Neptune */
- if (prev_count >= curr_count + 0x100)
- curr_count = get_8254_timer_count();
-
} while (prev_count >= curr_count);
}
@@ -1056,9 +1051,6 @@ static void __init wait_8254_wraparound(
* this function twice on the boot CPU, once with a bogus timeout
* value, second time for real. The other (noncalibrating) CPUs
* call this function only once, with the real, calibrated value.
- *
- * We do reads before writes even if unnecessary, to get around the
- * P5 APIC double write bug.
*/
#define APIC_DIVISOR 1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/APIC: drop 32-bit days remnants
2022-01-17 10:33 [PATCH] x86/APIC: drop 32-bit days remnants Jan Beulich
@ 2022-01-20 16:11 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2022-01-20 16:11 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
On 17/01/2022 10:33, Jan Beulich wrote:
> Mercury and Neptune were Pentium chipsets - no need to work around their
> errata, even more so that the workaround looks fragile.
>
> Also ditch a Pentium-related and stale part of a comment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Lets hope we don't have something other than Mercury/Neptune depends on
this.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-20 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17 10:33 [PATCH] x86/APIC: drop 32-bit days remnants Jan Beulich
2022-01-20 16:11 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).