* [PATCH] arm: fix Dom build after cd8015b634
@ 2018-09-25 12:56 Jan Beulich
2018-09-25 13:02 ` Andrew Cooper
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2018-09-25 12:56 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Julien Grall, Stefano Stabellini
The removal of the VLA there has changed sizeof() for the array.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Untested; purely based on looking at the code.
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -568,7 +568,7 @@ static int __init make_memory_node(const struct domain *d,
dt_child_set_range(&cells, addrcells, sizecells, start, size);
}
- res = fdt_property(fdt, "reg", reg, sizeof(reg));
+ res = fdt_property(fdt, "reg", reg, nr_cells * sizeof(*reg));
if ( res )
return res;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: fix Dom build after cd8015b634
2018-09-25 12:56 [PATCH] arm: fix Dom build after cd8015b634 Jan Beulich
@ 2018-09-25 13:02 ` Andrew Cooper
2018-09-25 16:20 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2018-09-25 13:02 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Julien Grall, Stefano Stabellini
On 25/09/18 13:56, Jan Beulich wrote:
> The removal of the VLA there has changed sizeof() for the array.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Untested; purely based on looking at the code.
Oops. Yes - that will cause things to go wrong.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: fix Dom build after cd8015b634
2018-09-25 13:02 ` Andrew Cooper
@ 2018-09-25 16:20 ` Julien Grall
0 siblings, 0 replies; 3+ messages in thread
From: Julien Grall @ 2018-09-25 16:20 UTC (permalink / raw)
To: Andrew Cooper, Jan Beulich, xen-devel; +Cc: Stefano Stabellini
Hi,
On 25/09/18 14:02, Andrew Cooper wrote:
> On 25/09/18 13:56, Jan Beulich wrote:
>> The removal of the VLA there has changed sizeof() for the array.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Untested; purely based on looking at the code.
I have tested it, it resolved the boot.
>
> Oops. Yes - that will cause things to go wrong.
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Julien Grall <julien.grall@arm.com>
And pushed.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-25 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-25 12:56 [PATCH] arm: fix Dom build after cd8015b634 Jan Beulich
2018-09-25 13:02 ` Andrew Cooper
2018-09-25 16:20 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).