* [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e
@ 2019-11-11 20:55 Andrew Cooper
2019-11-12 8:39 ` Jan Beulich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrew Cooper @ 2019-11-11 20:55 UTC (permalink / raw)
To: Xen-devel; +Cc: Juergen Gross, Andrew Cooper, Jennifer Herbert, Jan Beulich
"AMD/IOMMU: don't blindly allocate interrupt remapping tables" introduces a
call at runtime from amd_iommu_add_device() to amd_iommu_set_intremap_table()
which is still marked as __init.
On one AMD Rome machine we have, this results in a crash the moment we try to
use an SR-IOV VF in a VM.
Reported-by: Jennifer Herbert <jennifer.herbert@citrix.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>
For 4.13. This is a regression vs 4.12
---
xen/drivers/passthrough/amd/iommu_map.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c
index 2859d8257e..f3fcfb9e0f 100644
--- a/xen/drivers/passthrough/amd/iommu_map.c
+++ b/xen/drivers/passthrough/amd/iommu_map.c
@@ -112,7 +112,7 @@ void amd_iommu_set_root_page_table(struct amd_iommu_dte *dte,
dte->v = valid;
}
-void __init amd_iommu_set_intremap_table(
+void amd_iommu_set_intremap_table(
struct amd_iommu_dte *dte, const void *ptr,
const struct amd_iommu *iommu, bool valid)
{
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e
2019-11-11 20:55 [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e Andrew Cooper
@ 2019-11-12 8:39 ` Jan Beulich
2019-11-12 8:40 ` Jürgen Groß
2019-11-14 11:45 ` Jennifer Herbert
2 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2019-11-12 8:39 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Juergen Gross, Xen-devel, Jennifer Herbert
On 11.11.2019 21:55, Andrew Cooper wrote:
> "AMD/IOMMU: don't blindly allocate interrupt remapping tables" introduces a
> call at runtime from amd_iommu_add_device() to amd_iommu_set_intremap_table()
> which is still marked as __init.
>
> On one AMD Rome machine we have, this results in a crash the moment we try to
> use an SR-IOV VF in a VM.
>
> Reported-by: Jennifer Herbert <jennifer.herbert@citrix.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
I'm sorry for the breakage - I recall having made the change, so I must
have lost it at some point.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e
2019-11-11 20:55 [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e Andrew Cooper
2019-11-12 8:39 ` Jan Beulich
@ 2019-11-12 8:40 ` Jürgen Groß
2019-11-14 11:45 ` Jennifer Herbert
2 siblings, 0 replies; 4+ messages in thread
From: Jürgen Groß @ 2019-11-12 8:40 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Jennifer Herbert, Jan Beulich
On 11.11.19 21:55, Andrew Cooper wrote:
> "AMD/IOMMU: don't blindly allocate interrupt remapping tables" introduces a
> call at runtime from amd_iommu_add_device() to amd_iommu_set_intremap_table()
> which is still marked as __init.
>
> On one AMD Rome machine we have, this results in a crash the moment we try to
> use an SR-IOV VF in a VM.
>
> Reported-by: Jennifer Herbert <jennifer.herbert@citrix.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e
2019-11-11 20:55 [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e Andrew Cooper
2019-11-12 8:39 ` Jan Beulich
2019-11-12 8:40 ` Jürgen Groß
@ 2019-11-14 11:45 ` Jennifer Herbert
2 siblings, 0 replies; 4+ messages in thread
From: Jennifer Herbert @ 2019-11-14 11:45 UTC (permalink / raw)
To: Xen-devel; +Cc: Juergen Gross, Andrew Cooper
On 11/11/19 20:55, Andrew Cooper wrote:
> "AMD/IOMMU: don't blindly allocate interrupt remapping tables" introduces a
> call at runtime from amd_iommu_add_device() to amd_iommu_set_intremap_table()
> which is still marked as __init.
>
> On one AMD Rome machine we have, this results in a crash the moment we try to
> use an SR-IOV VF in a VM.
>
> Reported-by: Jennifer Herbert <jennifer.herbert@citrix.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Tested-by: Jennifer Herbert <jennifer.herbert@citrix.com>
This fixes the fatal page fault I found, which wasn't seen on 4.11.
Cheers,
-Jenny
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-14 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 20:55 [Xen-devel] [PATCH] AMD/IOMMU: Fix passthrough following c/s d7cfeb7c13e Andrew Cooper
2019-11-12 8:39 ` Jan Beulich
2019-11-12 8:40 ` Jürgen Groß
2019-11-14 11:45 ` Jennifer Herbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).