xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [Xen-devel] [PATCH] xen: remove empty softirq_init()
@ 2020-02-11 12:37 Juergen Gross
  2020-02-11 12:39 ` Andrew Cooper
  0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2020-02-11 12:37 UTC (permalink / raw)
  To: xen-devel
  Cc: Juergen Gross, Stefano Stabellini, Julien Grall, Wei Liu,
	Konrad Rzeszutek Wilk, George Dunlap, Andrew Cooper, Ian Jackson,
	Jan Beulich, Volodymyr Babchuk, Roger Pau Monné

softirq_init() is empty since Sen 4.1. Remove it together with its call
sites.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/arm/setup.c      | 2 --
 xen/arch/x86/setup.c      | 1 -
 xen/common/softirq.c      | 4 ----
 xen/include/xen/softirq.h | 1 -
 4 files changed, 8 deletions(-)

diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 3c8ae11b73..7968cee47d 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -876,8 +876,6 @@ void __init start_xen(unsigned long boot_phys_offset,
 
     gic_init();
 
-    softirq_init();
-
     tasklet_subsys_init();
 
     if ( xsm_dt_init() != 1 )
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index e50e1f86b3..3fbaee156d 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1533,7 +1533,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
     console_init_ring();
     vesa_init();
 
-    softirq_init();
     tasklet_subsys_init();
 
     paging_init();
diff --git a/xen/common/softirq.c b/xen/common/softirq.c
index 2d66193203..b83ad96d6c 100644
--- a/xen/common/softirq.c
+++ b/xen/common/softirq.c
@@ -132,10 +132,6 @@ void raise_softirq(unsigned int nr)
     set_bit(nr, &softirq_pending(smp_processor_id()));
 }
 
-void __init softirq_init(void)
-{
-}
-
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/xen/softirq.h b/xen/include/xen/softirq.h
index d7273b389b..b4724f5c8b 100644
--- a/xen/include/xen/softirq.h
+++ b/xen/include/xen/softirq.h
@@ -25,7 +25,6 @@ typedef void (*softirq_handler)(void);
 
 void do_softirq(void);
 void open_softirq(int nr, softirq_handler handler);
-void softirq_init(void);
 
 void cpumask_raise_softirq(const cpumask_t *, unsigned int nr);
 void cpu_raise_softirq(unsigned int cpu, unsigned int nr);
-- 
2.16.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Xen-devel] [PATCH] xen: remove empty softirq_init()
  2020-02-11 12:37 [Xen-devel] [PATCH] xen: remove empty softirq_init() Juergen Gross
@ 2020-02-11 12:39 ` Andrew Cooper
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2020-02-11 12:39 UTC (permalink / raw)
  To: Juergen Gross, xen-devel
  Cc: Stefano Stabellini, Julien Grall, Wei Liu, Konrad Rzeszutek Wilk,
	George Dunlap, Ian Jackson, Jan Beulich, Volodymyr Babchuk,
	Roger Pau Monné

On 11/02/2020 12:37, Juergen Gross wrote:
> softirq_init() is empty since Sen 4.1. Remove it together with its call
> sites.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-11 12:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 12:37 [Xen-devel] [PATCH] xen: remove empty softirq_init() Juergen Gross
2020-02-11 12:39 ` Andrew Cooper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).