From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Ed White <edmund.h.white@intel.com>
Cc: Tim Deegan <tim@xen.org>, Ravi Sahita <ravi.sahita@intel.com>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jun Nakajima <jun.nakajima@intel.com>,
tlengyel@novetta.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v6 05/15] x86/altp2m: basic data structures and support routines.
Date: Tue, 21 Jul 2015 13:46:37 +0100 [thread overview]
Message-ID: <55AE3F2D.7010400@citrix.com> (raw)
In-Reply-To: <55AE37680200007800093959@prv-mh.provo.novell.com>
On 07/21/2015 11:13 AM, Jan Beulich wrote:
>>>> On 21.07.15 at 01:58, <edmund.h.white@intel.com> wrote:
>> Add the basic data structures needed to support alternate p2m's and
>> the functions to initialise them and tear them down.
>>
>> Although Intel hardware can handle 512 EPTP's per hardware thread
>> concurrently, only 10 per domain are supported in this patch for
>> performance reasons.
>>
>> The iterator in hap_enable() does need to handle 512, so that is now
>> uint16_t.
>
> Sigh - this one is still here (and the respective code unchanged).
> I'm not going to NAK the patch just because of this, but it really
> looks like you aren't trying to address comments even when
> they're trivial (and quick) to carry out and testing of the change
> comes as a side effect of you needing to test all the other changes
> as well.
>
>> --- a/xen/arch/x86/hvm/Makefile
>> +++ b/xen/arch/x86/hvm/Makefile
>> @@ -1,6 +1,7 @@
>> subdir-y += svm
>> subdir-y += vmx
>>
>> +obj-y += altp2m.o
>
> Wasn't the outcome of the earlier discussion to put this in x86/mm,
> or possibly not even introduce a new file?
That was my recommendation [1] in response to v5, but there was no
response. The mail seems to have been seen, however, since Andrew's
Reviewed-by was dropped. (Perhaps they didn't notice the additional
comment further down.)
[1] marc.info/?i=<55A53159.4010703@eu.citrix.com>
> Overall the situation didn't really change from v5 - the code from
> a pure functionality pov looks okay, but I don't see myself giving
> in on all the "minor" issues the patch introduces. If some were
> left adjusting of which really takes time to or risks breaking the
> code, I'd (reluctantly) give my ack, but not this way, I'm afraid.
This is a bit puzzling, and somewhat frustrating too -- to have
carefully combed through past versions, seen the comments and
discussion, and then carefully combed through this one to find that
nearly none of them have been addressed, even minor ones.
-George
next prev parent reply other threads:[~2015-07-21 12:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 23:57 [PATCH v6 00/15] Alternate p2m: support multiple copies of host p2m Ed White
2015-07-20 23:57 ` [PATCH v6 01/15] common/domain: Helpers to pause a domain while in context Ed White
2015-07-21 10:06 ` George Dunlap
2015-07-20 23:57 ` [PATCH v6 02/15] VMX: VMFUNC and #VE definitions and detection Ed White
2015-07-20 23:57 ` [PATCH v6 03/15] VMX: implement suppress #VE Ed White
2015-07-21 0:40 ` Nakajima, Jun
2015-07-20 23:58 ` [PATCH v6 04/15] x86/HVM: Hardware alternate p2m support detection Ed White
2015-07-20 23:58 ` [PATCH v6 05/15] x86/altp2m: basic data structures and support routines Ed White
2015-07-21 10:13 ` Jan Beulich
2015-07-21 12:46 ` George Dunlap [this message]
2015-07-22 5:36 ` Sahita, Ravi
2015-07-22 7:51 ` Jan Beulich
2015-07-20 23:58 ` [PATCH v6 06/15] VMX/altp2m: add code to support EPTP switching and #VE Ed White
2015-07-20 23:58 ` [PATCH v6 07/15] VMX: add VMFUNC leaf 0 (EPTP switching) to emulator Ed White
2015-07-22 7:42 ` Jan Beulich
2015-07-20 23:58 ` [PATCH v6 08/15] x86/altp2m: add control of suppress_ve Ed White
2015-07-20 23:58 ` [PATCH v6 09/15] x86/altp2m: alternate p2m memory events Ed White
2015-07-20 23:58 ` [PATCH v6 10/15] x86/altp2m: add remaining support routines Ed White
2015-07-21 13:19 ` George Dunlap
2015-07-22 5:36 ` Sahita, Ravi
2015-07-20 23:58 ` [PATCH v6 11/15] x86/altp2m: define and implement alternate p2m HVMOP types Ed White
2015-07-22 7:50 ` Jan Beulich
2015-07-20 23:58 ` [PATCH v6 12/15] x86/altp2m: Add altp2mhvm HVM domain parameter Ed White
2015-07-20 23:58 ` [PATCH v6 13/15] x86/altp2m: XSM hooks for altp2m HVM ops Ed White
2015-07-20 23:58 ` [PATCH v6 14/15] tools/libxc: add support to altp2m hvmops Ed White
2015-07-20 23:58 ` [PATCH v6 15/15] tools/xen-access: altp2m testcases Ed White
2015-07-21 5:20 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE3F2D.7010400@citrix.com \
--to=george.dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=edmund.h.white@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=ravi.sahita@intel.com \
--cc=tim@xen.org \
--cc=tlengyel@novetta.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).