From: "Jan Beulich" <JBeulich@suse.com>
To: Ed White <edmund.h.white@intel.com>
Cc: Tim Deegan <tim@xen.org>, Ravi Sahita <ravi.sahita@intel.com>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jun Nakajima <jun.nakajima@intel.com>,
tlengyel@novetta.com, Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v6 07/15] VMX: add VMFUNC leaf 0 (EPTP switching) to emulator.
Date: Wed, 22 Jul 2015 01:42:16 -0600 [thread overview]
Message-ID: <55AF65780200007800093D92@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1437436691-24449-8-git-send-email-edmund.h.white@intel.com>
>>> On 21.07.15 at 01:58, <edmund.h.white@intel.com> wrote:
> @@ -1838,6 +1839,19 @@ static void vmx_vcpu_update_vmfunc_ve(struct vcpu *v)
> vmx_vmcs_exit(v);
> }
>
> +static int vmx_vcpu_emulate_vmfunc(struct cpu_user_regs *regs)
> +{
> + int rc = X86EMUL_EXCEPTION;
> + struct vcpu *curr = current;
> +
> + if ( !cpu_has_vmx_vmfunc && altp2m_active(curr->domain) &&
> + regs->_eax == 0 &&
> + p2m_switch_vcpu_altp2m_by_id(curr, (uint16_t)regs->_ecx) )
Didn't you say in the other mail that you addressed all review
comments? Switching from ->ecx to ->_ecx here makes no
difference at all as long as you don't also drop the wrong cast.
With the cast dropped
Acked-by: Jan Beulich <jbeulich@suse.com>
Jan
next prev parent reply other threads:[~2015-07-22 7:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 23:57 [PATCH v6 00/15] Alternate p2m: support multiple copies of host p2m Ed White
2015-07-20 23:57 ` [PATCH v6 01/15] common/domain: Helpers to pause a domain while in context Ed White
2015-07-21 10:06 ` George Dunlap
2015-07-20 23:57 ` [PATCH v6 02/15] VMX: VMFUNC and #VE definitions and detection Ed White
2015-07-20 23:57 ` [PATCH v6 03/15] VMX: implement suppress #VE Ed White
2015-07-21 0:40 ` Nakajima, Jun
2015-07-20 23:58 ` [PATCH v6 04/15] x86/HVM: Hardware alternate p2m support detection Ed White
2015-07-20 23:58 ` [PATCH v6 05/15] x86/altp2m: basic data structures and support routines Ed White
2015-07-21 10:13 ` Jan Beulich
2015-07-21 12:46 ` George Dunlap
2015-07-22 5:36 ` Sahita, Ravi
2015-07-22 7:51 ` Jan Beulich
2015-07-20 23:58 ` [PATCH v6 06/15] VMX/altp2m: add code to support EPTP switching and #VE Ed White
2015-07-20 23:58 ` [PATCH v6 07/15] VMX: add VMFUNC leaf 0 (EPTP switching) to emulator Ed White
2015-07-22 7:42 ` Jan Beulich [this message]
2015-07-20 23:58 ` [PATCH v6 08/15] x86/altp2m: add control of suppress_ve Ed White
2015-07-20 23:58 ` [PATCH v6 09/15] x86/altp2m: alternate p2m memory events Ed White
2015-07-20 23:58 ` [PATCH v6 10/15] x86/altp2m: add remaining support routines Ed White
2015-07-21 13:19 ` George Dunlap
2015-07-22 5:36 ` Sahita, Ravi
2015-07-20 23:58 ` [PATCH v6 11/15] x86/altp2m: define and implement alternate p2m HVMOP types Ed White
2015-07-22 7:50 ` Jan Beulich
2015-07-20 23:58 ` [PATCH v6 12/15] x86/altp2m: Add altp2mhvm HVM domain parameter Ed White
2015-07-20 23:58 ` [PATCH v6 13/15] x86/altp2m: XSM hooks for altp2m HVM ops Ed White
2015-07-20 23:58 ` [PATCH v6 14/15] tools/libxc: add support to altp2m hvmops Ed White
2015-07-20 23:58 ` [PATCH v6 15/15] tools/xen-access: altp2m testcases Ed White
2015-07-21 5:20 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AF65780200007800093D92@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=edmund.h.white@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jun.nakajima@intel.com \
--cc=ravi.sahita@intel.com \
--cc=tim@xen.org \
--cc=tlengyel@novetta.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).