Re: [PATCH] x86/HVM: honor p2m_ram_ro in hvm_map_guest_frame_rw()

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
	suravee.suthikulpanit@amd.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Eddie Dong <eddie.dong@intel.com>,
	Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
	Jun Nakajima <jun.nakajima@intel.com>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/HVM: honor p2m_ram_ro in hvm_map_guest_frame_rw()
Date: Fri, 31 Jul 2015 12:06:20 -0400	[thread overview]
Message-ID: <55BB9CFC.5010002@oracle.com> (raw)
In-Reply-To: <55B224660200007800095083@prv-mh.provo.novell.com>

On 07/24/2015 05:41 AM, Jan Beulich wrote:
>   
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -1619,10 +1619,23 @@ int nvmx_handle_vmptrld(struct cpu_user_
>   
>       if ( nvcpu->nv_vvmcxaddr == VMCX_EADDR )
>       {
> -        nvcpu->nv_vvmcx = hvm_map_guest_frame_rw(gpa >> PAGE_SHIFT, 1);
> -        if ( nvcpu->nv_vvmcx )
> -            nvcpu->nv_vvmcxaddr = gpa;
> -        if ( !nvcpu->nv_vvmcx ||
> +        bool_t writable;
> +        void *vvmcx = hvm_map_guest_frame_rw(paddr_to_pfn(gpa), 1, &writable);
> +

...

> @@ -1693,14 +1703,22 @@ int nvmx_handle_vmclear(struct cpu_user_
>       else
>       {
>           /* Even if this VMCS isn't the current one, we must clear it. */
> -        vvmcs = hvm_map_guest_frame_rw(gpa >> PAGE_SHIFT, 0);
> +        bool_t writable;
> +
> +        vvmcs = hvm_map_guest_frame_rw(gpa >> PAGE_SHIFT, 0, &writable);

Since you replaced 'gpa >> PAGE_SHIFT' with 'paddr_to_pfn(gpa' above, 
perhaps it should be replaced here too.

Other than that,
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>