* [PATCHv1] hvmloader: add high memory e820 region if needed
@ 2016-03-14 17:53 David Vrabel
2016-03-14 17:56 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: David Vrabel @ 2016-03-14 17:53 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, David Vrabel, Jan Beulich
If the MMIO hole is large and hvmloader needs to relocate memory to
immediately above the 4 GiB boundary, the e820 presented to the guest
will not have a RAM region above 4 GiB.
e.g., a guest with 3 GiB of memory and a 2 GiB MMIO hole will only see
2 GiB.
The required e820 memory region above 4 GiB needs to be added, and not
just filled in.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
tools/firmware/hvmloader/e820.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/firmware/hvmloader/e820.c b/tools/firmware/hvmloader/e820.c
index bbde2be..5541b18 100644
--- a/tools/firmware/hvmloader/e820.c
+++ b/tools/firmware/hvmloader/e820.c
@@ -99,6 +99,7 @@ void adjust_memory_map(void)
((uint64_t)hvm_info->high_mem_pgend << PAGE_SHIFT) -
memory_map.map[i].addr;
memory_map.map[i].type = E820_RAM;
+ memory_map.nr_map++;
}
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv1] hvmloader: add high memory e820 region if needed
2016-03-14 17:53 [PATCHv1] hvmloader: add high memory e820 region if needed David Vrabel
@ 2016-03-14 17:56 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2016-03-14 17:56 UTC (permalink / raw)
To: David Vrabel, xen-devel; +Cc: Jan Beulich
On 14/03/16 17:53, David Vrabel wrote:
> If the MMIO hole is large and hvmloader needs to relocate memory to
> immediately above the 4 GiB boundary, the e820 presented to the guest
> will not have a RAM region above 4 GiB.
>
> e.g., a guest with 3 GiB of memory and a 2 GiB MMIO hole will only see
> 2 GiB.
>
> The required e820 memory region above 4 GiB needs to be added, and not
> just filled in.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-14 17:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-14 17:53 [PATCHv1] hvmloader: add high memory e820 region if needed David Vrabel
2016-03-14 17:56 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).