From: "Jan Beulich" <JBeulich@suse.com>
To: Kevin Tian <kevin.tian@intel.com>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
Feng Wu <feng.wu@intel.com>, Quan Xu <quan.xu@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v7 2/2] VT-d: Fix vt-d Device-TLB flush timeout issue
Date: Thu, 17 Mar 2016 03:43:11 -0600 [thread overview]
Message-ID: <56EA8A3F02000078000DDA2B@prv-mh.provo.novell.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D15F7EC904@SHSMSX101.ccr.corp.intel.com>
>>> On 17.03.16 at 09:17, <kevin.tian@intel.com> wrote:
>> From: Xu, Quan
>> Sent: Thursday, March 17, 2016 3:13 PM
>> --- a/xen/drivers/passthrough/vtd/qinval.c
>> +++ b/xen/drivers/passthrough/vtd/qinval.c
>> @@ -233,6 +233,57 @@ int qinval_device_iotlb(struct iommu *iommu,
>> return 0;
>> }
>>
>> +static void dev_invalidate_iotlb_timeout(struct iommu *iommu, u16 did,
>> + u16 seg, u8 bus, u8 devfn)
>> +{
>> + struct domain *d = NULL;
>> + struct pci_dev *pdev;
>> +
>> + if ( test_bit(did, iommu->domid_bitmap) )
>> + d = rcu_lock_domain_by_id(iommu->domid_map[did]);
>> +
>> + if ( d == NULL )
>> + return;
>> +
>> + pcidevs_lock();
>> + for_each_pdev(d, pdev)
>
> we need a 'safe' version here since you're deleting nodes
> when walking list. for_each_pdev today is based on
> list_for_each_entry. Or if it's sure that only one pdev
> can match, we can break out of the loop to do removal.
But breaking out of the loop is what is already being done ...
>> + {
>> + if ( ( pdev->seg == seg ) &&
>> + ( pdev->bus == bus ) &&
>> + ( pdev->devfn == devfn ) )
>> + {
>> + ASSERT ( pdev->domain );
>> + list_del(&pdev->domain_list);
>> + pdev->domain = NULL;
>> + pci_hide_existing_device(pdev);
>> + break;
... here.
>> + }
>> + }
>> +
>> + pcidevs_unlock();
No need for using "safe" list traversal afaict.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-17 9:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 7:12 [PATCH v7 0/2] VT-d Device-TLB flush issue Quan Xu
2016-03-17 7:12 ` [PATCH v7 1/2] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed Quan Xu
2016-03-17 7:45 ` Tian, Kevin
2016-03-17 8:11 ` Xu, Quan
2016-03-17 8:13 ` Jan Beulich
2016-03-17 8:17 ` Xu, Quan
2016-03-17 7:12 ` [PATCH v7 2/2] VT-d: Fix vt-d Device-TLB flush timeout issue Quan Xu
2016-03-17 8:17 ` Tian, Kevin
2016-03-17 9:43 ` Jan Beulich [this message]
2016-03-17 11:13 ` Tian, Kevin
2016-03-17 11:30 ` Xu, Quan
2016-03-17 11:32 ` Tian, Kevin
2016-03-17 11:33 ` Jan Beulich
2016-03-18 12:21 ` Xu, Quan
2016-03-21 3:27 ` Tian, Kevin
2016-03-23 2:12 ` Xu, Quan
2016-03-23 3:29 ` Xu, Quan
2016-03-23 5:36 ` Tian, Kevin
2016-03-23 5:39 ` Xu, Quan
2016-03-18 11:18 ` Jan Beulich
2016-03-18 11:31 ` Xu, Quan
2016-03-18 13:35 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EA8A3F02000078000DDA2B@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=kevin.tian@intel.com \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).