xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Fu Wei <fu.wei@linaro.org>, dgdegra@tycho.nsa.gov
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	jcm@redhat.com, julien.grall@linaro.org,
	leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/arm64: check XSM Magic and Signature from the second unknown module.
Date: Fri, 18 Mar 2016 02:24:54 -0600	[thread overview]
Message-ID: <56EBC96602000078000DE3AB@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1458286908-27677-1-git-send-email-fu.wei@linaro.org>

>>> On 18.03.16 at 08:41, <fu.wei@linaro.org> wrote:
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -163,6 +163,36 @@ static void __init process_memory_node(const void *fdt, int node,
>      }
>  }
> +static bool __init check_xsm_signature(const void *fdt, int node,
> +                                       const char *name,
> +                                       u32 address_cells, u32 size_cells)
> +{
> +    uint32_t selinux_magic = 0xf97cff8c;

So this would be the 3rd instance of this literal number in the source
base. I would have wanted to suggest using one of the two
constants we already have, but I don't know which one to pick.

Daniel - why do we have both XSM_MAGIC and FLASK_MAGIC?


Xen-devel mailing list

  reply	other threads:[~2016-03-18  8:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  7:41 [PATCH] xen/arm64: check XSM Magic and Signature from the second unknown module fu.wei
2016-03-18  8:24 ` Jan Beulich [this message]
2016-03-18  9:48   ` Fu Wei
2016-03-25 21:02     ` Daniel De Graaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EBC96602000078000DE3AB@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=fu.wei@linaro.org \
    --cc=jcm@redhat.com \
    --cc=julien.grall@linaro.org \
    --cc=leif.lindholm@linaro.org \
    --cc=linaro-uefi@lists.linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).