From: Julien Grall <julien.grall@arm.com> To: Shannon Zhao <zhaoshenglong@huawei.com>, xen-devel@lists.xen.org Cc: stefano.stabellini@citrix.com, shannon.zhao@linaro.org, peter.huangpeng@huawei.com Subject: Re: [PATCH v6 11/22] arm/acpi: Prepare EFI system table for Dom0 Date: Mon, 21 Mar 2016 16:10:14 +0000 [thread overview] Message-ID: <56F01CE6.9040009@arm.com> (raw) In-Reply-To: <1458207668-12012-12-git-send-email-zhaoshenglong@huawei.com> Hi Shannon, On 17/03/2016 09:40, Shannon Zhao wrote: [...] > diff --git a/xen/arch/arm/efi/efi-dom0.c b/xen/arch/arm/efi/efi-dom0.c > index 90a7699..b8a062c 100644 > --- a/xen/arch/arm/efi/efi-dom0.c > +++ b/xen/arch/arm/efi/efi-dom0.c > @@ -48,3 +48,47 @@ size_t __init estimate_efi_size(int mem_nr_banks) > > return size; > } > + > +#include "../../../common/decompress.h" > +#define XZ_EXTERN STATIC > +#include "../../../common/xz/crc32.c" All the includes should be at the beginning of the file. > + > +void __init acpi_create_efi_system_table(paddr_t paddr, void *efi_acpi_table, > + struct membank tbl_add[]) > +{ > + u64 table_addr, table_size, offset = 0; > + u8 *base_ptr; > + EFI_CONFIGURATION_TABLE *efi_conf_tbl; > + EFI_SYSTEM_TABLE *efi_sys_tbl; > + > + table_addr = paddr + acpi_get_table_offset(tbl_add, TBL_EFIT); > + table_size = sizeof(EFI_SYSTEM_TABLE) + sizeof(EFI_CONFIGURATION_TABLE) > + + sizeof(xen_efi_fw_vendor); > + base_ptr = efi_acpi_table + acpi_get_table_offset(tbl_add, TBL_EFIT); > + efi_sys_tbl = (EFI_SYSTEM_TABLE *)base_ptr; > + > + efi_sys_tbl->Hdr.Signature = EFI_SYSTEM_TABLE_SIGNATURE; > + /* Specify the revision as 2.5 */ > + efi_sys_tbl->Hdr.Revision = (2 << 16 | 50); > + efi_sys_tbl->Hdr.HeaderSize = table_size; > + > + efi_sys_tbl->FirmwareRevision = 1; > + efi_sys_tbl->NumberOfTableEntries = 1; > + offset += sizeof(EFI_SYSTEM_TABLE); > + memcpy((CHAR16 *)(base_ptr + offset), xen_efi_fw_vendor, Why the cast to CHAR16? > + sizeof(xen_efi_fw_vendor)); > + efi_sys_tbl->FirmwareVendor = (CHAR16 *)(table_addr + offset); > + > + offset += sizeof(xen_efi_fw_vendor); > + efi_conf_tbl = (EFI_CONFIGURATION_TABLE *)(base_ptr + offset); > + efi_conf_tbl->VendorGuid = (EFI_GUID)ACPI_20_TABLE_GUID; > + efi_conf_tbl->VendorTable = (VOID *)tbl_add[TBL_RSDP].start; > + efi_sys_tbl->ConfigurationTable = (EFI_CONFIGURATION_TABLE *)(table_addr > + + offset); > + xz_crc32_init(); > + efi_sys_tbl->Hdr.CRC32 = xz_crc32((uint8_t *)efi_sys_tbl, > + efi_sys_tbl->Hdr.HeaderSize, 0); > + > + tbl_add[TBL_EFIT].start = table_addr; > + tbl_add[TBL_EFIT].size = table_size; > +} [...] Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-21 16:10 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-17 9:40 [PATCH v6 00/22] Prepare UEFI and ACPI tables for Dom0 on ARM64 Shannon Zhao 2016-03-17 9:40 ` [PATCH v6 01/22] arm/acpi: Estimate memory required for acpi/efi tables Shannon Zhao 2016-03-18 18:44 ` Julien Grall 2016-03-21 13:01 ` Jan Beulich 2016-03-22 13:01 ` Shannon Zhao 2016-03-22 0:28 ` Julien Grall 2016-03-24 12:36 ` Stefano Stabellini 2016-03-17 9:40 ` [PATCH v6 02/22] arm/acpi: Add a helper function to get the acpi table offset Shannon Zhao 2016-03-21 12:16 ` Julien Grall 2016-03-24 12:32 ` Stefano Stabellini 2016-03-17 9:40 ` [PATCH v6 03/22] arm/acpi: Prepare FADT table for Dom0 Shannon Zhao 2016-03-21 12:25 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 04/22] arm/gic: Add a new callback for creating MADT " Shannon Zhao 2016-03-21 15:18 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 05/22] arm/acpi: Prepare " Shannon Zhao 2016-03-21 15:26 ` Julien Grall 2016-03-21 15:51 ` Jan Beulich 2016-03-17 9:40 ` [PATCH v6 06/22] arm/acpi: Prepare STAO " Shannon Zhao 2016-03-21 15:31 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 07/22] arm/acpi: Prepare XSDT " Shannon Zhao 2016-03-21 15:43 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 08/22] arm/acpi: Prepare RSDP " Shannon Zhao 2016-03-21 15:47 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 09/22] arm/p2m: Add helper functions to map memory regions Shannon Zhao 2016-03-21 15:52 ` Julien Grall 2016-03-22 13:05 ` Shannon Zhao 2016-03-22 15:59 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 10/22] arm/acpi: Map all other tables for Dom0 Shannon Zhao 2016-03-21 15:57 ` Julien Grall 2016-03-17 9:40 ` [PATCH v6 11/22] arm/acpi: Prepare EFI system table " Shannon Zhao 2016-03-21 16:10 ` Julien Grall [this message] 2016-03-22 13:06 ` Shannon Zhao 2016-03-22 13:24 ` Jan Beulich 2016-03-17 9:40 ` [PATCH v6 12/22] arm/acpi: Prepare EFI memory descriptor " Shannon Zhao 2016-03-21 16:51 ` Julien Grall 2016-03-22 13:16 ` Shannon Zhao 2016-03-22 16:04 ` Julien Grall 2016-03-24 15:06 ` Shannon Zhao 2016-03-24 15:23 ` Julien Grall 2016-03-24 12:39 ` Stefano Stabellini 2016-03-17 9:40 ` [PATCH v6 13/22] arm/acpi: Map the new created EFI and ACPI tables to Dom0 Shannon Zhao 2016-03-22 0:42 ` Julien Grall 2016-03-22 13:18 ` Shannon Zhao 2016-03-22 16:16 ` Julien Grall 2016-03-24 14:59 ` Shannon Zhao 2016-03-24 15:35 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 14/22] arm/acpi: Create min DT stub for Dom0 Shannon Zhao 2016-03-22 1:07 ` Julien Grall 2016-03-22 13:23 ` Shannon Zhao 2016-03-17 9:41 ` [PATCH v6 15/22] arm/acpi: Permit access all Xen unused SPIs " Shannon Zhao 2016-03-22 18:18 ` Julien Grall 2016-03-24 15:01 ` Shannon Zhao 2016-03-24 15:37 ` Julien Grall 2016-03-25 7:13 ` Shannon Zhao 2016-03-17 9:41 ` [PATCH v6 16/22] arm/acpi: Configure SPI interrupt type and route to Dom0 dynamically Shannon Zhao 2016-03-22 19:17 ` Julien Grall 2016-03-24 12:41 ` Stefano Stabellini 2016-03-17 9:41 ` [PATCH v6 17/22] arm/gic: Add a new callback to deny Dom0 access to GIC regions Shannon Zhao 2016-03-22 19:33 ` Julien Grall 2016-03-24 12:45 ` Stefano Stabellini 2016-03-24 15:03 ` Shannon Zhao 2016-03-24 15:39 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 18/22] arm/acpi: Permit MMIO access of Xen unused devices for Dom0 Shannon Zhao 2016-03-23 11:50 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 19/22] hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao 2016-03-17 10:42 ` Jan Beulich 2016-03-17 11:04 ` Shannon Zhao 2016-03-17 11:29 ` Jan Beulich 2016-03-17 11:56 ` Shannon Zhao 2016-03-17 12:42 ` Jan Beulich 2016-03-17 9:41 ` [PATCH v6 20/22] xen/acpi: Fix event-channel interrupt when booting with ACPI Shannon Zhao 2016-03-23 12:15 ` Julien Grall 2016-03-17 9:41 ` [PATCH v6 21/22] xen/arm: Add a hypercall for device mmio mapping Shannon Zhao 2016-03-17 9:41 ` [PATCH v6 22/22] xen/arm64: Add ACPI support Shannon Zhao 2016-03-17 10:52 ` Jan Beulich 2016-03-17 11:03 ` Shannon Zhao 2016-03-17 11:31 ` Jan Beulich 2016-03-17 13:10 ` Shannon Zhao 2016-03-17 13:24 ` Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56F01CE6.9040009@arm.com \ --to=julien.grall@arm.com \ --cc=peter.huangpeng@huawei.com \ --cc=shannon.zhao@linaro.org \ --cc=stefano.stabellini@citrix.com \ --cc=xen-devel@lists.xen.org \ --cc=zhaoshenglong@huawei.com \ --subject='Re: [PATCH v6 11/22] arm/acpi: Prepare EFI system table for Dom0' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).